From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbaJOH4O (ORCPT ); Wed, 15 Oct 2014 03:56:14 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:40867 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbaJOH4M convert rfc822-to-8bit (ORCPT ); Wed, 15 Oct 2014 03:56:12 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform From: Kumar Gala In-Reply-To: <543D4C87.9050703@mm-sol.com> Date: Wed, 15 Oct 2014 09:56:02 +0200 Cc: Bjorn Andersson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-arm-msm , "Ivan T. Ivanov" Content-Transfer-Encoding: 8BIT Message-Id: References: <1409672443-4289-1-git-send-email-gdjakov@mm-sol.com> <1409672443-4289-4-git-send-email-gdjakov@mm-sol.com> <543D4C87.9050703@mm-sol.com> To: Georgi Djakov X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 14, 2014, at 6:17 PM, Georgi Djakov wrote: > On 10/10/2014 08:14 PM, Bjorn Andersson wrote: >> On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov wrote: >>> Enable support for the two SD host controllers on the APQ8084 platform >>> by adding the required nodes to the DT files. >>> On the IFC6540 board, the first controller is connected to the onboard >>> eMMC and the second is connected to a micro-SD card slot. >>> >>> Signed-off-by: Georgi Djakov >> >> Hi Georgi, >> >> This looks sane, but... >> >>> --- >>> arch/arm/boot/dts/qcom-apq8084-ifc6540.dts | 11 +++++++++++ >>> arch/arm/boot/dts/qcom-apq8084.dtsi | 23 +++++++++++++++++++++++ >>> 2 files changed, 34 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >>> index e41cb8a..c9ff108 100644 >>> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >>> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts >> [..] >>> + sdhci@f98a4900 { >>> + cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>; >>> + bus-width = <4>; >> >> ...why do you add this node and leave it disabled in the dts? >> > > Hi Bjorn, > Currently only the eMMC is functional on this board, so now we > have just the board specific configuration under this node. > More patches are forthcoming. Can we add something in the commit message to denote this. - k -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project