From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753077AbbIQByt (ORCPT ); Wed, 16 Sep 2015 21:54:49 -0400 Received: from mga14.intel.com ([192.55.52.115]:14786 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584AbbIQBys convert rfc822-to-8bit (ORCPT ); Wed, 16 Sep 2015 21:54:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,543,1437462000"; d="scan'208";a="806857153" From: "Wu, Feng" To: Paolo Bonzini , "alex.williamson@redhat.com" , "joro@8bytes.org" , "mtosatti@redhat.com" CC: "eric.auger@linaro.org" , "kvm@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Wu, Feng" Subject: RE: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Thread-Topic: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Thread-Index: AQHQ8GHiOHOUJZfON0u32xKNleFRWZ4/86JA Date: Thu, 17 Sep 2015 01:51:01 +0000 Message-ID: References: <1442393409-2623-1-git-send-email-feng.wu@intel.com> <1442393409-2623-10-git-send-email-feng.wu@intel.com> <55F935E9.6070707@redhat.com> In-Reply-To: <55F935E9.6070707@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > Sent: Wednesday, September 16, 2015 5:27 PM > To: Wu, Feng; alex.williamson@redhat.com; joro@8bytes.org; > mtosatti@redhat.com > Cc: eric.auger@linaro.org; kvm@vger.kernel.org; > iommu@lists.linux-foundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct > kvm_kernel_irqfd' > > > > On 16/09/2015 10:50, Feng Wu wrote: > > +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq, > > + uint32_t guest_irq, bool set) > > +{ > > + return !kvm_x86_ops->update_pi_irte ? -EINVAL : > > + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set); > > +} > > + > > Just use "if" here. No need to resend if this is the only comment. I am sorry, I don't quite understand. Do you mean I don't need to include this patch in v9? If so, what about other patches with your Reviewed-by? Thanks, Feng > > > > > } > > +int __attribute__((weak)) kvm_arch_update_irqfd_routing( > > + struct kvm *kvm, unsigned > > Empty line after "}". > > Paolo