From: Marcel Holtmann <marcel@holtmann.org>
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc: BlueZ <linux-bluetooth@vger.kernel.org>,
Alain Michaud <alainm@chromium.org>,
ChromeOS Bluetooth Upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Johan Hedberg <johan.hedberg@gmail.com>,
netdev <netdev@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] Bluetooth: Don't restart scanning if paused
Date: Wed, 24 Jun 2020 21:40:03 +0200 [thread overview]
Message-ID: <EAEF89F3-8F6B-49AE-95B4-E6A961C6474D@holtmann.org> (raw)
In-Reply-To: <20200624113351.1.Ic6b1fca2b1b3fe989db21ceae76bab80bd87d387@changeid>
Hi Abhishek,
> When restarting LE scanning, check if it's currently paused before
> enabling passive scanning.
>
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> ---
> When running suspend stress tests on Chromebooks, we discovered
> instances where the Chromebook didn't enter the deepest idle states
> (i.e. S0ix). After some debugging, we found that passive scanning was
> being enabled AFTER the suspend notifier had run (and disabled all
> scanning).
>
> For this fix, I simply looked at all the places where we call
> HCI_OP_LE_SET_SCAN_ENABLE and added a guard clause for suspend. With
> this fix, we were able to get through 100+ iterations of the suspend
> stress test without any problems entering S0ix.
>
>
> net/bluetooth/hci_request.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2020-06-24 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 18:34 [PATCH] Bluetooth: Don't restart scanning if paused Abhishek Pandit-Subedi
2020-06-24 19:40 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EAEF89F3-8F6B-49AE-95B4-E6A961C6474D@holtmann.org \
--to=marcel@holtmann.org \
--cc=abhishekpandit@chromium.org \
--cc=alainm@chromium.org \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=davem@davemloft.net \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).