From: Norman Maurer <norman.maurer@googlemail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, dsahern@kernel.org
Subject: Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)
Date: Fri, 26 Mar 2021 11:38:28 +0100 [thread overview]
Message-ID: <EC14C055-97AE-4A33-B39C-24944B02932F@googlemail.com> (raw)
In-Reply-To: <8eadc07055ac1c99bbc55ea10c7b98acc36dde55.camel@redhat.com>
Hi,
> On 26. Mar 2021, at 10:36, Paolo Abeni <pabeni@redhat.com> wrote:
>
> Hello,
>
> On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote:
>> From: Norman Maurer <norman_maurer@apple.com>
>>
>> Support for UDP_GRO was added in the past but the implementation for
>> getsockopt was missed which did lead to an error when we tried to
>> retrieve the setting for UDP_GRO. This patch adds the missing switch
>> case for UDP_GRO
>>
>> Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.")
>> Signed-off-by: Norman Maurer <norman_maurer@apple.com>
>
> The patch LGTM, but please cc the blamed commit author in when you add
> a 'Fixes' tag (me in this case ;)
Noted for the next time…
>
> Also please specify a target tree, either 'net' or 'net-next', in the
> patch subj. Being declared as a fix, this should target 'net'.
>
Ok noted
> One thing you can do to simplifies the maintainer's life, would be post
> a v2 with the correct tag (and ev. obsolete this patch in patchwork).
I am quite new to contribute patches to the kernel so I am not sure how I would “obsolete” this patch and make a v2. If you can give me some pointers I am happy to do so.
>
> Side note: I personally think this is more a new feature (is adds
> getsockopt support for UDP_GRO) than a fix, so I would not have added
> the 'Fixes' tag and I would have targeted net-next, but it's just my
> opinion.
I see… For me it seemed more like a bug as I can’t think of a reason why only setsockopt should be supported for an option but not getsockopt. But it may be just my opinion :)
>
> Cheers,
>
> Paolo
>
Thanks
Norman
prev parent reply other threads:[~2021-03-26 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 19:56 [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...); Norman Maurer
2021-03-26 9:36 ` [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...) Paolo Abeni
2021-03-26 10:22 ` Norman Maurer
2021-03-26 12:22 ` Paolo Abeni
2021-03-31 13:10 ` Norman Maurer
2021-03-31 13:18 ` Paolo Abeni
2021-04-01 0:18 ` David Ahern
2021-04-01 7:01 ` Norman Maurer
2021-03-26 10:25 ` Norman Maurer
2021-03-26 10:38 ` Norman Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC14C055-97AE-4A33-B39C-24944B02932F@googlemail.com \
--to=norman.maurer@googlemail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).