From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522Ab2IQKdI (ORCPT ); Mon, 17 Sep 2012 06:33:08 -0400 Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:2322 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752313Ab2IQKdF convert rfc822-to-8bit (ORCPT ); Mon, 17 Sep 2012 06:33:05 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -11 X-BigFish: VS-11(zz98dI9371I103dK1b0bI542M1432Izz1202h1d1ah1d2ahzz8275dhz2dh2a8h668h839h8e2h8e3h944hd25hf0ah107ah1220h1288h12a5h12a9h12bdhbe9i1155h) From: Xie Shaohui-B21989 To: Shaun Ruffell CC: "linux-edac@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "akpm@linux-foundation.org" , "avorontsov@mvista.com" , "linux-kernel@vger.kernel.org" , "grant.likely@secretlab.ca" Subject: RE: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe Thread-Topic: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe Thread-Index: AQHNkaMM7ec3MtYj5keBzMlX2iUaRpeKfBmAgAPeSnA= Date: Mon, 17 Sep 2012 10:32:59 +0000 Message-ID: References: <1347533729-5893-1-git-send-email-Shaohui.Xie@freescale.com> <20120914182137.GD18672@digium.com> In-Reply-To: <20120914182137.GD18672@digium.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.193.20.41] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Shaun Ruffell [mailto:sruffell@digium.com] > Sent: Saturday, September 15, 2012 2:22 AM > To: Xie Shaohui-B21989 > Cc: linux-edac@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > akpm@linux-foundation.org; avorontsov@mvista.com; linux- > kernel@vger.kernel.org; grant.likely@secretlab.ca > Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe > > On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote: > > Error handle in case of DDR ECC off is wrong, sysfs entries have not > > been created, so edac_mc_free which frees a mci instance should not be > called. > > Also, free mci's memory in this case. > > Jus FYI: I ran into the same error in edac_mc_free() which I resolved in > a slightly different way in some patches I sent previously. [1] > > [1] https://lkml.org/lkml/2012/9/14/475 [S.H] Thanks! I did not aware of this patch when one of my colleague asked me to have a look at the issue, It could save me some time if I saw this patch earlier. :( BTW: seems you are using a different kernel tree with mine. Best Regards, Shaohui Xie