* RE: ACPI sleep: stupid bug reintroduced
@ 2002-10-01 22:41 Grover, Andrew
0 siblings, 0 replies; 2+ messages in thread
From: Grover, Andrew @ 2002-10-01 22:41 UTC (permalink / raw)
To: 'Pavel Machek',
Rusty trivial patch monkey Russell, ACPI mailing list,
kernel list
> From: Pavel Machek [mailto:pavel@ucw.cz]
> There's extremely stupid bug in sleep.c -- it will only alow user to
> enter *unsupported* states. What's even worse that I remember fixing
> that once before, and *it was merged to mainline*.
Cough cough Pat... ;-)
It's (re-)fixed in my bk tree already. Didn't have this bit at the end so
I'll apply that.
Regards -- Andy
> +#else
> + return_VALUE(-ENODEV);
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* ACPI sleep: stupid bug reintroduced
@ 2002-10-01 21:40 Pavel Machek
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2002-10-01 21:40 UTC (permalink / raw)
To: Andrew Grover, Rusty trivial patch monkey Russell,
ACPI mailing list, kernel list
Hi!
There's extremely stupid bug in sleep.c -- it will only alow user to
enter *unsupported* states. What's even worse that I remember fixing
that once before, and *it was merged to mainline*.
Please, really merge it to all copies so it is not reintroduced again.
[Oh, at it also makes S4 transition fail when SWSUSP support is not
there.]
Pavel
--- clean/drivers/acpi/sleep.c 2002-09-22 23:46:56.000000000 +0200
+++ linux-swsusp/drivers/acpi/sleep.c 2002-10-01 23:38:48.000000000 +0200
@@ -329,8 +329,8 @@
state_string[count] = '\0';
state = simple_strtoul(state_string, NULL, 0);
-
- if (sleep_states[state])
+
+ if (!sleep_states[state])
return_VALUE(-ENODEV);
#ifdef CONFIG_SOFTWARE_SUSPEND
@@ -338,7 +338,10 @@
software_suspend();
return_VALUE(count);
}
+#else
+ return_VALUE(-ENODEV);
#endif
+
status = acpi_suspend(state);
if (ACPI_FAILURE(status))
--
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-10-01 22:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-01 22:41 ACPI sleep: stupid bug reintroduced Grover, Andrew
-- strict thread matches above, loose matches on Subject: below --
2002-10-01 21:40 Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).