From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbcBJOpg (ORCPT ); Wed, 10 Feb 2016 09:45:36 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:53689 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbcBJOpb convert rfc822-to-8bit (ORCPT ); Wed, 10 Feb 2016 09:45:31 -0500 From: Gabriele Paoloni To: Mark Rutland CC: "Guohanjun (Hanjun Guo)" , "Wangzhou (B)" , "liudongdong (C)" , Linuxarm , qiujiang , "bhelgaas@google.com" , "arnd@arndb.de" , "Lorenzo.Pieralisi@arm.com" , "tn@semihalf.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "xuwei (O)" , "linux-acpi@vger.kernel.org" , "jcm@redhat.com" , zhangjukuo , "Liguozhu (Kenneth)" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [RFC PATCH v3 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Thread-Topic: [RFC PATCH v3 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers Thread-Index: AQHRY2BPDAt3I/onv0+w21i+svfmsZ8kB3mAgAD/zGCAABncAIAAOS2w Date: Wed, 10 Feb 2016 14:45:09 +0000 Message-ID: References: <1455039260-6040-1-git-send-email-gabriele.paoloni@huawei.com> <1455039260-6040-4-git-send-email-gabriele.paoloni@huawei.com> <20160209182429.GD4348@leverpostej> <20160210111234.GC2632@leverpostej> In-Reply-To: <20160210111234.GC2632@leverpostej> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.156] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.56BB4D07.02F2,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 105d5e57177bfbceb8cf4a65fda1cb17 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Mark Rutland > Sent: 10 February 2016 11:13 > To: Gabriele Paoloni > Cc: Guohanjun (Hanjun Guo); Wangzhou (B); liudongdong (C); Linuxarm; > qiujiang; bhelgaas@google.com; arnd@arndb.de; > Lorenzo.Pieralisi@arm.com; tn@semihalf.com; linux-pci@vger.kernel.org; > linux-kernel@vger.kernel.org; xuwei (O); linux-acpi@vger.kernel.org; > jcm@redhat.com; zhangjukuo; Liguozhu (Kenneth); linux-arm- > kernel@lists.infradead.org > Subject: Re: [RFC PATCH v3 3/3] PCI/ACPI: hisi: Add ACPI support for > HiSilicon SoCs Host Controllers > > On Wed, Feb 10, 2016 at 09:52:36AM +0000, Gabriele Paoloni wrote: > > Hi Mark > > > > > On Tue, Feb 09, 2016 at 05:34:20PM +0000, Gabriele Paoloni wrote: > > > > From: gabriele paoloni > > > > +/* > > > > + * Retrieve rc_dbi base and size from _DSD > > > > + * Name (_DSD, Package () { > > > > + * ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > > > > + * Package () { > > > > + * Package () {"rc-dbi", Package () { 0x0, 0xb0080000, 0x0, > 0x10000 > > > }}, > > > > + * } > > > > + * }) > > > > + */ > > > > > > As above, this does not look right. ACPI has standard mechanisms > for > > > describing addresses. Making something up like this is not a good > idea. > > > > I am quite new to ACPI, may I ask you to explain a bit? > > ACPI has standard mechanisms for describing certain resources, and > these > should not be described in _DSD. Memory or IO address regions are such > resources (in _CRS, IIRC), and should not be described in _DSD. Hi Mark, In my case I think in need to look into the MCFG object as the problem I have is RC using a different range than the rest of the hierarchy. I'll investigate this and try to come with a solution in v4 Many Thanks Gab > > Thanks, > Mark.