From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755571AbdERKIm convert rfc822-to-8bit (ORCPT ); Thu, 18 May 2017 06:08:42 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:6353 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbdERKIj (ORCPT ); Thu, 18 May 2017 06:08:39 -0400 From: Gabriele Paoloni To: Christoph Hellwig CC: "bhelgaas@google.com" , "helgaas@kernel.org" , Linuxarm , "linux-pci@vger.kernel.org" , "lukas@wunner.de" , "linux-kernel@vger.kernel.org" , "mika.westerberg@linux.intel.com" , "liudongdong (C)" Subject: RE: [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Thread-Topic: [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Thread-Index: AQHSz7VtN2O4w3ahu0agGPa08DBO/6H5sLcAgAAs0FA= Date: Thu, 18 May 2017 10:08:15 +0000 Message-ID: References: <1495098098-1984-1-git-send-email-gabriele.paoloni@huawei.com> <1495098098-1984-2-git-send-email-gabriele.paoloni@huawei.com> <20170518092630.GA28006@infradead.org> In-Reply-To: <20170518092630.GA28006@infradead.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.162] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.591D729E.00CA,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.104, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: a32d783341818aea3a11b9609a381209 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph > -----Original Message----- > From: linux-pci-owner@vger.kernel.org [mailto:linux-pci- > owner@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: 18 May 2017 10:27 > To: Gabriele Paoloni > Cc: bhelgaas@google.com; helgaas@kernel.org; Linuxarm; linux- > pci@vger.kernel.org; lukas@wunner.de; linux-kernel@vger.kernel.org; > mika.westerberg@linux.intel.com; hch@infradead.org; liudongdong (C) > Subject: Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > > - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for > given port > > + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as > interrupt mode > > + * for given port > > just rename it to pcie_port_enable_vecs to avoid the overly long line.. The function is actually renamed but I missed to update the comment, my bad. > > > + * pci_irq_vector() below is able to handle entry > differently > > + * depending on MSI vs MSI-x case > > As mentioned in the review for the other patch: no need to repeat > this for every user of pci_irq_vector. I also missed to remove this comment > > Otherwise this looks fine to me: > > Reviewed-by: Christoph Hellwig Many thanks I'll fix comments and send out v3 straight Cheers Gab