From: Kees Cook <kees@kernel.org>
To: "Joan Bruguera Micó" <joanbrugueram@gmail.com>,
"Thorsten Leemhuis" <linux@leemhuis.info>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: build error while building arch/x86/purgatory/sha256.o: invalid 'asm': operand is not a condition code [...]
Date: Mon, 29 May 2023 21:23:39 -0700 [thread overview]
Message-ID: <EE2A76DE-973F-4FCD-AEC8-C24D9FFCC3F1@kernel.org> (raw)
In-Reply-To: <20230528164031.266590-1-joanbrugueram@gmail.com>
On May 28, 2023 9:40:31 AM PDT, "Joan Bruguera Micó" <joanbrugueram@gmail.com> wrote:
>I can also reproduce the problem with Arch's linux-next-git, see config:
>https://aur.archlinux.org/cgit/aur.git/tree/config?h=linux-next-git&id=f9a384e1c582321651fb613782ebc5a581146af0
>
>I've bisected it to df8fc4e934c1 ("kbuild: Enable -fstrict-flex-arrays=3"),
>which explains why it only happens on GCC13.
>
>The problematic expansion that causes the error seems to be this fragment
>from `_BUG_FLAGS` in `arch/x86/include/asm/bug.h`:
> asm(".long %c0 - .\n": : "i" (__FILE__));
>
>Along with the fact that this file is built with `-mcmodel=large`
>(see `PURGATORY_CFLAGS` in `arch/x86/purgatory/Makefile`).
I haven't reproduced this yet, but the error implies that the asm input "i"mmediate value of the __FILE__ string address cannot be used with the asm template format "%c0" (a constant value).
https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Generic-Operand-Modifiers
I cannot fathom why struct flex array logic would change that...
I'll take a closer look in the morning.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2023-05-30 4:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 11:34 build error while building arch/x86/purgatory/sha256.o: invalid 'asm': operand is not a condition code [...] Thorsten Leemhuis
2023-05-28 16:40 ` Joan Bruguera Micó
2023-05-28 18:17 ` Joan Bruguera Micó
2023-05-30 4:23 ` Kees Cook [this message]
2023-05-31 0:18 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EE2A76DE-973F-4FCD-AEC8-C24D9FFCC3F1@kernel.org \
--to=kees@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=joanbrugueram@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).