From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5666CC35246 for ; Tue, 28 Jan 2020 05:48:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2AEF424682 for ; Tue, 28 Jan 2020 05:48:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="Hma1sjKp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725867AbgA1Fsd (ORCPT ); Tue, 28 Jan 2020 00:48:33 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:46096 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbgA1Fsc (ORCPT ); Tue, 28 Jan 2020 00:48:32 -0500 Received: by mail-qk1-f196.google.com with SMTP id g195so12192449qke.13 for ; Mon, 27 Jan 2020 21:48:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=LCR4yoPyKXUQ+V6Rzx8Vr1pGJBzG7ybCO5xmGhWVO2E=; b=Hma1sjKpCAmCNDeQeafPYa2ae6jBDESB1PCm6wfy4m1d7M9+BWh8FVkywYWY7ykCiy SzQx25lgeC+4duHJWx6KqUIh8QXTw8di5MeaGwQuHHn89Nhc7uYjdWvvsMbKeA7vFD83 eZ0ttxqv+O0UBv0Q1ELfjNP83to7CnSAWkh7s2C27oDB+u7jHIZRBxLZHGidOdsQf1JK mEEo4/yiVKjxGyBlmRHpRnDqvkuHhNTxRoPqy1Zumzpfc60DAz3G+S+hPw5+FUChoT/q bS0YqS6g/Diq0QYdhlCFXqUUyepH5ufSRHLX0WMtxLjOyn6wC8W9mPq32swU9Z657Mb6 aYdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=LCR4yoPyKXUQ+V6Rzx8Vr1pGJBzG7ybCO5xmGhWVO2E=; b=oQz+qiO82Y6KdiB0D2WgL6TLKRm4j0bwssukByvulJf4VCKRzJ1eLk5Ft55GssEj9n yM0HKNSG+LgC2WvHYRVxALXXEH5wioj9rP6NDkPfpOXAwNmgftfQzr+WURUes1jwCCVg qgV3mIS890CQwA44D9ZCHjyftOH1lnp8ZdzA2vv2/1AHiQyXIjAWcT5qn26cD9SWYL4x sVzZAXhEnHkTYFm2hzlw5yar6ztSSsNxVwS5fbg6sAGYN4H6aS8iscQsyj5xiPmNt8aG ygOYi61HTW5RUvqZ1L2UPaLSG7I/QuNWxmWRWrFRp9RUPblZRpwEsnINg3EUsvlGtEN/ RwLA== X-Gm-Message-State: APjAAAVUHd25BgoLx9oTqsRQNW1PbILarfOx3ZZVavzia60lwhgcq/bV zqAq9I3hkAicTjWRayVHxT8OoA== X-Google-Smtp-Source: APXvYqwn3oHOOTfkm4bMswvjR/8+st1VKZNpzuQd0q1CmHzfURBt8o3+PL4pjZF1Mk5vBV26vMgvyQ== X-Received: by 2002:ae9:edc8:: with SMTP id c191mr20758894qkg.227.1580190511462; Mon, 27 Jan 2020 21:48:31 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id 8sm11519536qkm.92.2020.01.27.21.48.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2020 21:48:30 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH V12] mm/debug: Add tests validating architecture page table helpers Date: Tue, 28 Jan 2020 00:48:30 -0500 Message-Id: References: <012158b7-a40e-050f-cd1b-d6ce7faf042f@arm.com> Cc: Linux-MM , Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <012158b7-a40e-050f-cd1b-d6ce7faf042f@arm.com> To: Anshuman Khandual X-Mailer: iPhone Mail (17C54) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jan 27, 2020, at 11:58 PM, Anshuman Khandual wrote: >=20 > As I had mentioned before, the test attempts to formalize page table helpe= r semantics > as expected from generic MM code paths and intend to catch deviations when= enabled on > a given platform. How else should we test semantics errors otherwise ? The= re are past > examples of usefulness for this procedure on arm64 and on s390. I am wonde= ring how > else to prove the usefulness of a debug feature if these references are no= t enough. Not saying it will not be useful. As you mentioned it actually found a bug o= r two in the past. The problem is that there is always a cost to maintain so= mething like this, and nobody knew how things could be broken even for the i= solated code you mentioned in the future given how complicated the kernel co= de base is. I am not so positive that many developers would enable this debu= g feature and use it on a regular basis from the information you gave so far= .=20 On the other hand, it might just be good at maintaining this thing out of tr= ee by yourself anyway, because if there isn=E2=80=99t going to be used by ma= ny developers, few people is going to contribute to this and even noticed wh= en it is broken. What=E2=80=99s the point of getting this merged apart from b= eing getting some meaningless credits?=