From: Marcel Holtmann <marcel@holtmann.org>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
apusaka@chromium.org, abhishekpandit@chromium.org,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+7d41312fe3f123a6f605@syzkaller.appspotmail.com
Subject: Re: [PATCH] Bluetooth: hci: fix GPF in h5_recv
Date: Fri, 10 Sep 2021 09:39:14 +0200 [thread overview]
Message-ID: <EF01F61D-7765-49C1-A813-55EB130FCCE1@holtmann.org> (raw)
In-Reply-To: <20210902202756.25378-1-paskripkin@gmail.com>
Hi Pavel,
> Syzbot hit general protection fault in h5_recv(). The problem was in
> missing NULL check.
>
> hu->serdev can be NULL and we cannot blindly pass &serdev->dev
> somewhere, since it can cause GPF.
>
> Fixes: d9dd833cf6d2 ("Bluetooth: hci_h5: Add runtime suspend")
> Reported-and-tested-by: syzbot+7d41312fe3f123a6f605@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> ---
> drivers/bluetooth/hci_h5.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2021-09-10 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 20:27 [PATCH] Bluetooth: hci: fix GPF in h5_recv Pavel Skripkin
2021-09-10 7:39 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF01F61D-7765-49C1-A813-55EB130FCCE1@holtmann.org \
--to=marcel@holtmann.org \
--cc=abhishekpandit@chromium.org \
--cc=apusaka@chromium.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=paskripkin@gmail.com \
--cc=syzbot+7d41312fe3f123a6f605@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).