From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753172AbbGAJDJ (ORCPT ); Wed, 1 Jul 2015 05:03:09 -0400 Received: from mail-bl2on0060.outbound.protection.outlook.com ([65.55.169.60]:55168 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752637AbbGAJC6 convert rfc822-to-8bit (ORCPT ); Wed, 1 Jul 2015 05:02:58 -0400 X-Greylist: delayed 4698 seconds by postgrey-1.27 at vger.kernel.org; Wed, 01 Jul 2015 05:02:57 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none; From: Subbaraya Sundeep Bhatta To: "balbi@ti.com" CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: RE: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Thread-Topic: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails Thread-Index: AQHQk69GvvpKmr7PaEKjPX967XYJ0J3DvMeAgAK66JA= Date: Wed, 1 Jul 2015 07:29:28 +0000 Message-ID: References: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com> <1432203408-5482-3-git-send-email-sbhatta@xilinx.com> <20150629214701.GK1019@saruman.tx.rr.com> In-Reply-To: <20150629214701.GK1019@saruman.tx.rr.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.23.19.222] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21646.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC002;1:AjZvn5TDJhk6xpudoEp8Qq62bAFDtpuEv6GQzOp9MQ7TNJ5O2ecOpqTnsaaZlVOzNffi4ZiJ0A7gozxOSPEU1YtU1Zhrfn4zzVx7J0SnnUB79BnbVpBjGw+rjZsgboeI+itMxLjy0iwSC7fLotMs7jUAcIB293Uw+TXSHcrr7sTwk5zGRy9+d1HTtezqj8+K+NHewwUZ38vH6abUJnVjVj++O4oEQC9vmLirw9YD9Nq920DXckvmYa4Sm+FzLnrgzHXLdWieDXXK/Rtxki13x9oKF8YdThd9FbhnPUnzg5BHUpt+rPYFAFjBiaaKdvOJ X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(13464003)(377454003)(24454002)(199003)(189002)(164054003)(51704005)(46102003)(2351001)(2656002)(23726002)(47776003)(92566002)(76176999)(19580395003)(50986999)(19580405001)(54356999)(575784001)(106466001)(77156002)(62966003)(5003600100002)(33656002)(102836002)(50466002)(97756001)(2920100001)(15975445007)(55846006)(5250100002)(87936001)(46406003)(5001960100002)(2950100001)(110136002)(106116001)(63266004)(6806004)(189998001)(2900100001)(2501003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB024;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB024;2:8tTjC0hlisMpoyM7Lht+wXfVkDR+0vbf4+mieaCmz/4twkYsCh2TcUqS/OdUXoF5;3:yxRKv8UCIhSucH6CJJoNBp58/QXfjk9plDy6HU/6ExSMeJjhfWHyh4ETVas/Eue4WXeVYRfYYLffGX9SOw28iQPxYMKC8WYgpY3ueCV529GMu6S1nmjhtFSTKgCd3RWnjO+uWXLBVQbAt9HZaoLpPhWTC4S6TCTUoUTJwBwVSdcv+3karG75DJ5OFbQSh9eXIRJFzYNm1JP/3smz24+W21TLEigRq1iF6eVwm6um5t9LvBaja1F6YPRdgR1p9JDC;20:jyYwU9wjuYVAmL9aZdnk4bprq6V96tj45+Lya+t/wHZnab/Xo9vClSf4viY0HT/SwCFN76pqDerOq4/9pvxfoJXKdlfFEmMcgHUdj+tWGA/Qj8GPSa8wU1ercQ/C9E0D50d36vJH+jWMXgxxhpwXPx88pFmpsb1GaVQuhxQc+ODZjqnGfmitKrRYr4W49l/hsZsFd39pUAcJnhl4ahi0F/HXoVVaYPOavfiESr+SBHbsO/Nulwfb4xmhl84RVps6lbytheTU3nPgPhfKOiVvIExOS/icksg4bHl0ZZjuLTd0Hl2ngH7IBYhZxo5H5Xafo0CdsmNsCu3d4iXYjdQKyNV1Ex8Nsa87z+K4bCwYhcQfBBXXMRKFDz+xrchrZ8qQOepN9rOnmkVWDYLKdHmAQBkpjk/WXiyiwdcRq79CcdGi1EerBz9BmZD2FGJnziBdwJm0gTdvAH3c+Lt2dLOLPlGXxPOyKvJWwhZr8sOvrdm/sYQ+H7Moppj2e+4Fl9sv X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB024; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BL2FFO11HUB024;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB024; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB024;4:v/lmFMiAZHt5CM2196aeFCqZgvndZ6I5tYTRzygg0S0MFFNfJZf2vNKbwYjIsahbisj0G9v/oruUaZQuz4xG5TlmtDbblrAAAJ9+7N1pv+3jhSSzma05eH0lP5S7d62J+h10VDzBBlBBY/0LMf3PmMeA4TmVyvqO/l92nRJmL07+PXAkyJ/dwJx0mj+q6OktA6L6w+c/kyGgL3eeHB94Zq4DpLTJB6Su2E7SgocXA8BRNjfq8TVwa2utkvBt/ym3shMhpBN27CLe9t/VvxLDTb3a+dNkhaNaZU0HsQQpOWs= X-Forefront-PRVS: 0624A2429E X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2FFO11HUB024;23:jg6wTgoNf7zDZW/c1uuLwjJl4EgnbanG0EhoJm33?= =?us-ascii?Q?Nz3qWXoOAgpMMw03hgSnnKg27X7eAt++btnFzaMzXSpA8wuOPNUVaSGoSP96?= =?us-ascii?Q?/vlaaUwozPiS+JiHS+FykxpAQ/LDkKUyTNEs1CktepBINL0xl1+fj9Bmh0ew?= =?us-ascii?Q?SK+HXgIRo1pqoAWbHp/vakx5P7Y6KvQ9IcBGbKgpUgLb43LoPzOioKh4+TAt?= =?us-ascii?Q?/HzqNoxc+PLu/rcnaY864obbHejSl0q+HvHHVfzSTHO+mxBMa+4L/4LhjhS5?= =?us-ascii?Q?5X+ckqeP2ezhPF1EkM7nS0vlWVhy6nXRF/GoDM1Xz0Yne3KD7XWjbDxFE64W?= =?us-ascii?Q?IJhRa2k3l8TV1c8jRFCele3SaCvadPcubjWe+9ZiPYLJUWW45CZBnCgudC/W?= =?us-ascii?Q?E3vTT4zamR31OzTPKcaBl3Y5g3Qujyo/oyKVsUfc+loWeguaySjNW6ZvdxXY?= =?us-ascii?Q?vGn8ot1XiO+EvIDiZidEZ5OgY4eZ6Zi9jfBY4hI/7oKYWO5B5JHSwbliMmpr?= =?us-ascii?Q?JieK3eK0MF4ei1PPSHpZVqjoc3dnexslkYDuYq1VLUsdonmFIPkdvc8ODMnY?= =?us-ascii?Q?ghVXiIzSWHxDwLm7qRTI71QHuYmhfCmjdF6Vh+K/lXjqcfTTrjVX9+NDnyXy?= =?us-ascii?Q?/79SuVuaxtmklRhaSE8qN5BGe8JoOzkbC/V6JEE3HefuaQx6IrpEc4TSeAwl?= =?us-ascii?Q?EMUKxLxFpvjkmHa9todDPGMqx44Uguu9ZaUjZpZaDIfwZVWzT9GQhKovSCcd?= =?us-ascii?Q?LNz6WvpSMnxaFQlLOplcR5xHKdeyLTjH9hjV0eYaQ8PBnDvGP0hFupKNwL7J?= =?us-ascii?Q?gVb3DvSQ/bni5RGHXHblXol8N49CrVH0J7EkM9QGHtehKMHHuEx/fXAbqZ8x?= =?us-ascii?Q?2pNrFePdRxDBuN3DbOoeR2WIvp4Uinsb5+oEPWPvYcb4KfkF4jWZCtA8f4US?= =?us-ascii?Q?ow5qOF3JFXJnXlGWcSKx1jrOwPYGxxkdPbiQj2lVjT4rlOYc7TtMCecO+Sta?= =?us-ascii?Q?Mo2ETT7pa5yhTx9msT7Xqxxud44b8Mm3IDic4ToChmV2Ml78qP5ylZu+9I+W?= =?us-ascii?Q?3h0ssG3pvx2TZEjyRSjIkJIxt/plNofgXXVAH+9int9T0Kk+emtpXR31N+bL?= =?us-ascii?Q?Y8akOIS+Wb3uKqsGy0GAi8XqTdiS4FR8pbWWfh8fVVdEdv5/QMDj0M5wn6Cu?= =?us-ascii?Q?QKdwfYE98AuKHhI=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB024;5:mxrfL27zXaj4k9miZQmT3py9P4AM+Z0BNprnAa7ML+P/8rSSSk6K7yBC/B+J5WxpNFwwuSH3Cxa9CUess+5pXCr72gThOBTKx+TGoihZNjJ5DtbPSAtB0zF5QsCzbFOlnIgI8XhCMwITaJDwFruEIA==;24:VFSW26KQbz0lAQ0VbHMUxDz9cwqnNNOqeLEpF/1HOtj5dV11iY60VF+hAEf25N1IIfcmJdMemMB6XxsNo4AtuMaLr4XDj8ABe2UBIIttzhc= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2015 07:29:31.7666 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB024 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, > -----Original Message----- > From: Felipe Balbi [mailto:balbi@ti.com] > Sent: Tuesday, June 30, 2015 3:17 AM > To: Subbaraya Sundeep Bhatta > Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-kernel@vger.kernel.org; stable@vger.kernel.org; Subbaraya Sundeep > Bhatta > Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command > sent to DEPCMD register fails > > Hi, > > On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta > wrote: > > We need to return error to caller if command is not sent to controller > > succesfully. > > > > Signed-off-by: Subbaraya Sundeep Bhatta > > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver) > > Cc: > > --- > > v2 changes: > > Added Fixes and Cc in commit message. > > I noticed that this breaks at least my AM437x silicon with DWC3 2.40a > when used with g_zero and testusb. As of now, it could be that silicon is > mis-behaving because I got a Transfer Complete before the failing Set > Endpoint Transfer Resource command. > > In any case, can you run on your setup with g_zero and test.sh/testusb > [1]/[2] just to verify that it really works for you ? Ok I will do that. Thanks, Sundeep.B.S. > > Meanwhile, I'll continue testing on my end. > > cheers > > [1] https://gitorious.org/usb/usb- > tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c > [2] https://gitorious.org/usb/usb- > tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh > > -- > balbi