linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough
Date: Thu, 20 May 2021 11:47:13 -0400	[thread overview]
Message-ID: <F1DB079A-8194-41E3-BF15-EB6F5A23CDF7@goodmis.org> (raw)
In-Reply-To: <20210520230738.605c92033e16c13b86f7c99c@kernel.org>

Yeah, I have it cued up too. Can it wait till next week?

--Steve


On May 20, 2021 10:07:38 AM EDT, Masami Hiramatsu <mhiramat@kernel.org> wrote:
>Hi Steve,
>
>Can you pick at least this fix since it is a critical bug?
>
>Thank you,
>
>On Thu, 13 May 2021 12:06:33 +0900
>Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
>> Since the "fallthrough" is defined only in the kernel, building
>> lib/bootconfig.c as a part of user-space tools causes a build
>> error.
>> 
>> Add a dummy fallthrough to avoid the build error.
>> 
>> Cc: stable@vger.kernel.org
>> Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough
>pseudo-keyword in lib/"")
>> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
>> ---
>>  tools/bootconfig/include/linux/bootconfig.h |    4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/tools/bootconfig/include/linux/bootconfig.h
>b/tools/bootconfig/include/linux/bootconfig.h
>> index 078cbd2ba651..de7f30f99af3 100644
>> --- a/tools/bootconfig/include/linux/bootconfig.h
>> +++ b/tools/bootconfig/include/linux/bootconfig.h
>> @@ -4,4 +4,8 @@
>>  
>>  #include "../../../../include/linux/bootconfig.h"
>>  
>> +#ifndef fallthrough
>> +# define fallthrough
>> +#endif
>> +
>>  #endif
>> 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.

  reply	other threads:[~2021-05-20 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13  3:06 [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough Masami Hiramatsu
2021-05-20 14:07 ` Masami Hiramatsu
2021-05-20 15:47   ` Steven Rostedt [this message]
2021-05-20 23:07     ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F1DB079A-8194-41E3-BF15-EB6F5A23CDF7@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).