From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754536AbdFWI4E (ORCPT ); Fri, 23 Jun 2017 04:56:04 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:57753 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754068AbdFWI4B (ORCPT ); Fri, 23 Jun 2017 04:56:01 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH] Bluetooth: hci_serdev: make hci_serdev_client_ops static From: Marcel Holtmann In-Reply-To: <20170623083738.8836-1-colin.king@canonical.com> Date: Fri, 23 Jun 2017 10:55:53 +0200 Cc: "Gustavo F. Padovan" , Johan Hedberg , "open list:BLUETOOTH DRIVERS" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20170623083738.8836-1-colin.king@canonical.com> To: Colin King X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, > The structure hci_serdev_client_ops does not need to be in global scope > and is not modified, so make it static. > > Cleans up sparse warning: > "symbol 'hci_serdev_client_ops' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King > --- > drivers/bluetooth/hci_serdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel