From: "Li, Liang Z" <liang.z.li@intel.com>
To: "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"qemu-devel@nongun.org" <qemu-devel@nongun.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mst@redhat.com" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Amit Shah <amit.shah@redhat.com>
Subject: RE: [PATCH 1/6] virtio-balloon: rework deflate to add page to a list
Date: Thu, 23 Jun 2016 08:30:24 +0000 [thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E041F8277@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1465811233-21136-2-git-send-email-liang.z.li@intel.com>
Hi Michael,
Could you help to review this patch set and give some comments when you have time?
My work is blocked here.
Thanks !
Liang
> -----Original Message-----
> From: Li, Liang Z
> Sent: Monday, June 13, 2016 5:47 PM
> To: kvm@vger.kernel.org
> Cc: virtio-dev@lists.oasis-open.org; qemu-devel@nongun.org; linux-
> kernel@vger.kernel.org; mst@redhat.com; Li, Liang Z; Paolo Bonzini; Cornelia
> Huck; Amit Shah
> Subject: [PATCH 1/6] virtio-balloon: rework deflate to add page to a list
>
> will allow faster notifications using a bitmap down the road.
> Now balloon_pfn_to_page() can be removed because it is not used.
>
> Signed-off-by: Liang Li <liang.z.li@intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: Amit Shah <amit.shah@redhat.com>
> ---
> drivers/virtio/virtio_balloon.c | 22 ++++++++--------------
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 476c0e3..8d649a2 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -98,12 +98,6 @@ static u32 page_to_balloon_pfn(struct page *page)
> return pfn * VIRTIO_BALLOON_PAGES_PER_PAGE; }
>
> -static struct page *balloon_pfn_to_page(u32 pfn) -{
> - BUG_ON(pfn % VIRTIO_BALLOON_PAGES_PER_PAGE);
> - return pfn_to_page(pfn / VIRTIO_BALLOON_PAGES_PER_PAGE);
> -}
> -
> static void balloon_ack(struct virtqueue *vq) {
> struct virtio_balloon *vb = vq->vdev->priv; @@ -176,18 +170,16 @@
> static unsigned fill_balloon(struct virtio_balloon *vb, size_t num)
> return num_allocated_pages;
> }
>
> -static void release_pages_balloon(struct virtio_balloon *vb)
> +static void release_pages_balloon(struct virtio_balloon *vb,
> + struct list_head *pages)
> {
> - unsigned int i;
> - struct page *page;
> + struct page *page, *next;
>
> - /* Find pfns pointing at start of each page, get pages and free them.
> */
> - for (i = 0; i < vb->num_pfns; i +=
> VIRTIO_BALLOON_PAGES_PER_PAGE) {
> - page = balloon_pfn_to_page(virtio32_to_cpu(vb->vdev,
> - vb->pfns[i]));
> + list_for_each_entry_safe(page, next, pages, lru) {
> if (!virtio_has_feature(vb->vdev,
>
> VIRTIO_BALLOON_F_DEFLATE_ON_OOM))
> adjust_managed_page_count(page, 1);
> + list_del(&page->lru);
> put_page(page); /* balloon reference */
> }
> }
> @@ -197,6 +189,7 @@ static unsigned leak_balloon(struct virtio_balloon *vb,
> size_t num)
> unsigned num_freed_pages;
> struct page *page;
> struct balloon_dev_info *vb_dev_info = &vb->vb_dev_info;
> + LIST_HEAD(pages);
>
> /* We can only do one array worth at a time. */
> num = min(num, ARRAY_SIZE(vb->pfns));
> @@ -208,6 +201,7 @@ static unsigned leak_balloon(struct virtio_balloon *vb,
> size_t num)
> if (!page)
> break;
> set_page_pfns(vb, vb->pfns + vb->num_pfns, page);
> + list_add(&page->lru, &pages);
> vb->num_pages -= VIRTIO_BALLOON_PAGES_PER_PAGE;
> }
>
> @@ -219,7 +213,7 @@ static unsigned leak_balloon(struct virtio_balloon *vb,
> size_t num)
> */
> if (vb->num_pfns != 0)
> tell_host(vb, vb->deflate_vq);
> - release_pages_balloon(vb);
> + release_pages_balloon(vb, &pages);
> mutex_unlock(&vb->balloon_lock);
> return num_freed_pages;
> }
> --
> 1.9.1
next prev parent reply other threads:[~2016-06-23 8:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 9:47 [PATCH 0/6] Fast balloon & fast live migration Liang Li
2016-06-13 9:47 ` [PATCH 1/6] virtio-balloon: rework deflate to add page to a list Liang Li
2016-06-23 8:25 ` Li, Liang Z
2016-06-23 8:30 ` Li, Liang Z [this message]
2016-06-13 9:47 ` [PATCH 2/6] virtio-balloon: speed up inflate/deflate process Liang Li
2016-06-13 10:17 ` kbuild test robot
2016-06-24 5:39 ` Michael S. Tsirkin
2016-06-24 6:28 ` Li, Liang Z
2016-06-13 9:47 ` [PATCH 3/6] mm:split the drop cache operation into a function Liang Li
2016-06-13 9:47 ` [PATCH 4/6] virtio-balloon: add drop cache support Liang Li
2016-06-13 9:47 ` [PATCH 5/6] mm: add the related functions to get free page info Liang Li
2016-06-13 9:47 ` [PATCH 6/6] virtio-balloon: tell host vm's " Liang Li
2016-06-23 8:27 ` [PATCH 0/6] Fast balloon & fast live migration Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2CBF3009FA73547804AE4C663CAB28E041F8277@shsmsx102.ccr.corp.intel.com \
--to=liang.z.li@intel.com \
--cc=amit.shah@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongun.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).