linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Li, Liang Z" <liang.z.li@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"dgilbert@redhat.com" <dgilbert@redhat.com>,
	"quintela@redhat.com" <quintela@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Amit Shah <amit.shah@redhat.com>
Subject: RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process
Date: Thu, 28 Jul 2016 03:48:16 +0000	[thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E04213E86@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20160728010616-mutt-send-email-mst@kernel.org>

> > +/*
> > + * VIRTIO_BALLOON_PFNS_LIMIT is used to limit the size of page bitmap
> > + * to prevent a very large page bitmap, there are two reasons for this:
> > + * 1) to save memory.
> > + * 2) allocate a large bitmap may fail.
> > + *
> > + * The actual limit of pfn is determined by:
> > + * pfn_limit = min(max_pfn, VIRTIO_BALLOON_PFNS_LIMIT);
> > + *
> > + * If system has more pages than VIRTIO_BALLOON_PFNS_LIMIT, we will
> > +scan
> > + * the page list and send the PFNs with several times. To reduce the
> > + * overhead of scanning the page list. VIRTIO_BALLOON_PFNS_LIMIT
> > +should
> > + * be set with a value which can cover most cases.
> > + */
> > +#define VIRTIO_BALLOON_PFNS_LIMIT ((32 * (1ULL << 30)) >>
> PAGE_SHIFT)
> > +/* 32GB */
> > +
> >  static int oom_pages = OOM_VBALLOON_DEFAULT_PAGES;
> > module_param(oom_pages, int, S_IRUSR | S_IWUSR);
> > MODULE_PARM_DESC(oom_pages, "pages to free on OOM");
> >
> > +extern unsigned long get_max_pfn(void);
> > +
> 
> Please just include the correct header. No need for this hackery.
> 

Will change. Thanks!

Liang

  reply	other threads:[~2016-07-28  3:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  1:23 [PATCH v2 repost 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration Liang Li
2016-07-27  1:23 ` [PATCH v2 repost 1/7] virtio-balloon: rework deflate to add page to a list Liang Li
2016-07-27  1:23 ` [PATCH v2 repost 2/7] virtio-balloon: define new feature bit and page bitmap head Liang Li
2016-07-27  1:23 ` [PATCH v2 repost 3/7] mm: add a function to get the max pfn Liang Li
2016-07-27 22:08   ` Michael S. Tsirkin
2016-07-27 22:52     ` Dave Hansen
2016-07-27  1:23 ` [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process Liang Li
2016-07-27 16:03   ` Dave Hansen
2016-07-27 21:39     ` Michael S. Tsirkin
2016-07-28  3:30       ` Li, Liang Z
2016-07-28 22:15         ` Michael S. Tsirkin
2016-07-29  1:08           ` [virtio-dev] " Li, Liang Z
2016-07-28  1:13     ` Li, Liang Z
2016-07-28  1:45       ` Michael S. Tsirkin
2016-07-28  6:36         ` [virtio-dev] " Li, Liang Z
2016-07-28 21:51           ` Michael S. Tsirkin
2016-07-29  0:46             ` Li, Liang Z
2016-07-29 19:48             ` Dave Hansen
2016-08-02  0:28               ` Li, Liang Z
2016-07-27 21:36   ` Michael S. Tsirkin
2016-07-28  3:06     ` Li, Liang Z
2016-07-28 22:17       ` Michael S. Tsirkin
2016-07-29  0:38         ` Li, Liang Z
2016-07-27 22:07   ` Michael S. Tsirkin
2016-07-28  3:48     ` Li, Liang Z [this message]
2016-07-27  1:23 ` [PATCH v2 repost 5/7] virtio-balloon: define feature bit and head for misc virt queue Liang Li
2016-07-27  1:23 ` [PATCH v2 repost 6/7] mm: add the related functions to get free page info Liang Li
2016-07-27 16:40   ` Dave Hansen
2016-07-27 22:05     ` Michael S. Tsirkin
2016-07-27 22:16       ` Dave Hansen
2016-07-27 23:05         ` Michael S. Tsirkin
2016-07-28  4:36         ` Li, Liang Z
2016-07-28  0:10     ` Li, Liang Z
2016-07-28  0:17       ` Michael S. Tsirkin
2016-07-27 22:13   ` Michael S. Tsirkin
2016-07-28  5:30     ` [virtio-dev] " Li, Liang Z
2016-07-27  1:23 ` [PATCH v2 repost 7/7] virtio-balloon: tell host vm's " Liang Li
2016-07-27 22:00   ` Michael S. Tsirkin
2016-07-28  7:50     ` Li, Liang Z
2016-07-28 21:37       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F2CBF3009FA73547804AE4C663CAB28E04213E86@shsmsx102.ccr.corp.intel.com \
    --to=liang.z.li@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.shah@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dgilbert@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).