From: "Li, Liang Z" <liang.z.li@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mhocko@suse.com" <mhocko@suse.com>,
"mst@redhat.com" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>
Subject: RE: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration
Date: Fri, 9 Dec 2016 05:35:45 +0000 [thread overview]
Message-ID: <F2CBF3009FA73547804AE4C663CAB28E3A14E339@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <060287c7-d1af-45d5-70ea-ad35d4bbeb84@intel.com>
> On 12/08/2016 08:45 PM, Li, Liang Z wrote:
> > What's the conclusion of your discussion? It seems you want some
> > statistic before deciding whether to ripping the bitmap from the ABI,
> > am I right?
>
> I think Andrea and David feel pretty strongly that we should remove the
> bitmap, unless we have some data to support keeping it. I don't feel as
> strongly about it, but I think their critique of it is pretty valid. I think the
> consensus is that the bitmap needs to go.
>
Thanks for you clarification.
> The only real question IMNHO is whether we should do a power-of-2 or a
> length. But, if we have 12 bits, then the argument for doing length is pretty
> strong. We don't need anywhere near 12 bits if doing power-of-2.
>
So each item can max represent 16MB Bytes, seems not big enough,
but enough for most case.
Things became much more simple without the bitmap, and I like simple solution too. :)
I will prepare the v6 and remove all the bitmap related stuffs. Thank you all!
Liang
next prev parent reply other threads:[~2016-12-09 5:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 8:43 [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Liang Li
2016-11-30 8:43 ` [PATCH kernel v5 1/5] virtio-balloon: rework deflate to add page to a list Liang Li
2016-11-30 8:43 ` [PATCH kernel v5 2/5] virtio-balloon: define new feature bit and head struct Liang Li
2016-11-30 8:43 ` [PATCH kernel v5 3/5] virtio-balloon: speed up inflate/deflate process Liang Li
2016-11-30 8:43 ` [PATCH kernel v5 4/5] virtio-balloon: define flags and head for host request vq Liang Li
2016-11-30 8:43 ` [PATCH kernel v5 5/5] virtio-balloon: tell host vm's unused page info Liang Li
2016-11-30 19:15 ` Dave Hansen
2016-12-04 13:13 ` Li, Liang Z
2016-12-05 17:22 ` Dave Hansen
2016-12-06 4:47 ` Li, Liang Z
2016-12-06 8:40 ` [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration David Hildenbrand
2016-12-07 13:35 ` Li, Liang Z
2016-12-07 15:34 ` Dave Hansen
2016-12-09 3:09 ` Li, Liang Z
2016-12-07 15:42 ` David Hildenbrand
2016-12-07 15:45 ` Dave Hansen
2016-12-07 16:21 ` David Hildenbrand
2016-12-07 16:57 ` Dave Hansen
2016-12-07 18:38 ` [Qemu-devel] " Andrea Arcangeli
2016-12-07 18:44 ` Dave Hansen
2016-12-07 18:58 ` Andrea Arcangeli
2016-12-07 19:54 ` Dave Hansen
2016-12-07 20:28 ` Andrea Arcangeli
2016-12-09 4:45 ` Li, Liang Z
2016-12-09 4:53 ` Dave Hansen
2016-12-09 5:35 ` Li, Liang Z [this message]
2016-12-09 16:42 ` Andrea Arcangeli
2016-12-14 8:20 ` Li, Liang Z
2016-12-14 8:59 ` Li, Liang Z
2016-12-15 15:34 ` Dave Hansen
2016-12-15 15:54 ` Michael S. Tsirkin
2016-12-16 1:12 ` Li, Liang Z
2016-12-16 15:40 ` Andrea Arcangeli
2016-12-17 11:56 ` Li, Liang Z
2016-12-16 0:48 ` Li, Liang Z
2016-12-16 1:09 ` Dave Hansen
2016-12-16 1:38 ` Li, Liang Z
2016-12-16 1:40 ` Dave Hansen
2016-12-16 1:43 ` Li, Liang Z
2016-12-16 16:01 ` Andrea Arcangeli
2016-12-17 12:39 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2CBF3009FA73547804AE4C663CAB28E3A14E339@SHSMSX104.ccr.corp.intel.com \
--to=liang.z.li@intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).