From: hayeswang <hayeswang@realtek.com>
To: "'Francois Romieu'" <romieu@fr.zoreil.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving
Date: Wed, 24 Oct 2012 13:55:28 +0800 [thread overview]
Message-ID: <F44332CBDDB64F93B0BB3785EC1AD46E@realtek.com.tw> (raw)
In-Reply-To: <20121023193304.GB10463@electric-eye.fr.zoreil.com>
Francois Romieu [mailto:romieu@fr.zoreil.com]
[...]
> > +static void r810x_aldps_disable(struct rtl8169_private *tp)
> > +{
> > + rtl_writephy(tp, 0x1f, 0x0000);
> > + rtl_writephy(tp, 0x18, 0x0310);
> > + msleep(100);
> > +}
>
> rtl8402_hw_phy_config used a msleep(20). Meguesses it won't
> hurt, right ?
No, it won't hurt. The delay make suer there is enough time to pause ALDPS.
Best Regards,
Hayes
next prev parent reply other threads:[~2012-10-24 5:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 8:05 [PATCH net-next 1/2] r8169: enable ALDPS for power saving Hayes Wang
2012-10-22 17:59 ` David Miller
2012-10-22 19:27 ` Francois Romieu
2012-10-23 2:24 ` hayeswang
2012-10-23 19:31 ` Francois Romieu
2012-10-24 5:55 ` hayeswang
2012-10-24 20:05 ` Francois Romieu
2012-10-23 6:47 ` [PATCH v2 " Hayes Wang
2012-10-23 6:47 ` [PATCH v2 net-next 2/2] r8169: update the settings for RTL8111G Hayes Wang
2012-10-23 19:41 ` Francois Romieu
2012-10-23 19:33 ` [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving Francois Romieu
2012-10-24 5:55 ` hayeswang [this message]
2012-10-24 6:24 ` [PATCH v3 net-next] " Hayes Wang
2012-10-24 21:20 ` Francois Romieu
2012-10-26 6:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F44332CBDDB64F93B0BB3785EC1AD46E@realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).