From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933169AbcITQ46 convert rfc822-to-8bit (ORCPT ); Tue, 20 Sep 2016 12:56:58 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:3464 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932899AbcITQ4z (ORCPT ); Tue, 20 Sep 2016 12:56:55 -0400 From: Salil Mehta To: Leon Romanovsky CC: "dledford@redhat.com" , "Huwei (Xavier)" , oulijun , "Zhuangyuzeng (Yisen)" , "xuwei (O)" , "mehta.salil.lnk@gmail.com" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: RE: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state Thread-Topic: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state Thread-Index: AQHSCoLQwY2MHEBlokKkErzR5gpv0qB6TZ8AgAhcTOA= Date: Tue, 20 Sep 2016 16:56:35 +0000 Message-ID: References: <1473417051-99560-1-git-send-email-salil.mehta@huawei.com> <1473417051-99560-19-git-send-email-salil.mehta@huawei.com> <20160915101246.GX26069@leon.nu> In-Reply-To: <20160915101246.GX26069@leon.nu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.93.11] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.57E16A4E.0002,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 1e48bafb445f186c8b2eae28c57fb039 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Leon Romanovsky [mailto:leon@kernel.org] > Sent: Thursday, September 15, 2016 11:13 AM > To: Salil Mehta > Cc: dledford@redhat.com; Huwei (Xavier); oulijun; Zhuangyuzeng (Yisen); > xuwei (O); mehta.salil.lnk@gmail.com; linux-rdma@vger.kernel.org; > linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH for-next 18/20] IB/hns: Update the rq head when > modify qp state > > On Fri, Sep 09, 2016 at 06:30:49PM +0800, Salil Mehta wrote: > > From: Lijun Ou > > > > The rq head in qpc was zero will miss the rq wqes which > > have be sent, so here we should take the real value. > > > > Signed-off-by: Lijun Ou > > Reviewed-by: Wei Hu (Xavier) > > Signed-off-by: Salil Mehta > > --- > > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > > index bdd9453..7a61d7e 100644 > > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c > > @@ -2266,7 +2266,8 @@ static int hns_roce_v1_m_qp(struct ib_qp *ibqp, > const struct ib_qp_attr *attr, > > > > roce_set_field(context->qpc_bytes_68, > > QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_M, > > - QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_S, 0); > > + QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_S, > > + hr_qp->rq.head); > > Are you sure that it should be list_head and not value? This is correct. Variable head is not list_head but a u32 value. Hope I understood your point correctly. Best regards Salil > > > roce_set_field(context->qpc_bytes_68, > > QP_CONTEXT_QPC_BYTES_68_RQ_CUR_INDEX_M, > > QP_CONTEXT_QPC_BYTES_68_RQ_CUR_INDEX_S, 0); > > -- > > 1.7.9.5 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html