From: Salil Mehta <salil.mehta@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"Zhuangyuzeng (Yisen)" <yisen.zhuang@huawei.com>,
huangdaode <huangdaode@hisilicon.com>,
"lipeng (Y)" <lipeng321@huawei.com>,
"mehta.salil.lnk@gmail.com" <mehta.salil.lnk@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: RE: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver
Date: Thu, 27 Jul 2017 15:53:57 +0000 [thread overview]
Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93B828136@FRAEML521-MBX.china.huawei.com> (raw)
In-Reply-To: <20170723102601.18ac81a1@xeon-e3>
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Sunday, July 23, 2017 6:26 PM
> To: Salil Mehta
> Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y);
> mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm
> Subject: Re: [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to
> HNS3 driver
>
> On Sat, 22 Jul 2017 23:09:41 +0100
> Salil Mehta <salil.mehta@huawei.com> wrote:
>
> > + HNS3_NETDEV_STAT("rx_packets", rx_packets),
> > + HNS3_NETDEV_STAT("tx_packets", tx_packets),
> > + HNS3_NETDEV_STAT("rx_bytes", rx_bytes),
> > + HNS3_NETDEV_STAT("tx_bytes", tx_bytes),
> > + HNS3_NETDEV_STAT("rx_errors", rx_errors),
> > + HNS3_NETDEV_STAT("tx_errors", tx_errors),
> > + HNS3_NETDEV_STAT("rx_dropped", rx_dropped),
> > + HNS3_NETDEV_STAT("tx_dropped", tx_dropped),
> > + HNS3_NETDEV_STAT("multicast", multicast),
> > + HNS3_NETDEV_STAT("collisions", collisions),
> > +
> > + /* detailed Rx errors */
>
> Do not put network statistics in ethtool statistics.
> This is redundant and unnecessary. Yes some other drivers may do it
> but it is not best practice.
Ok sure, will remove netdev stats from the ethtool.
Thanks
Salil
next prev parent reply other threads:[~2017-07-27 15:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-22 22:09 [PATCH V4 net-next 0/8] Hisilicon Network Subsystem 3 Ethernet Driver Salil Mehta
2017-07-22 22:09 ` [PATCH V4 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Salil Mehta
2017-07-23 17:24 ` Florian Fainelli
2017-07-27 20:44 ` Salil Mehta
2017-08-02 16:38 ` Salil Mehta
2017-07-22 22:09 ` [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework Salil Mehta
2017-07-23 13:15 ` Leon Romanovsky
2017-07-27 23:44 ` Salil Mehta
2017-07-28 4:41 ` Leon Romanovsky
2017-07-28 11:52 ` Salil Mehta
2017-07-22 22:09 ` [PATCH V4 net-next 3/8] net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support Salil Mehta
2017-07-22 22:09 ` [PATCH V4 net-next 4/8] net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support Salil Mehta
2017-07-22 22:09 ` [PATCH V4 net-next 5/8] net: hns3: Add support of TX Scheduler & Shaper to HNS3 driver Salil Mehta
2017-07-23 6:16 ` Richard Cochran
2017-07-23 9:31 ` Salil Mehta
2017-07-22 22:09 ` [PATCH V4 net-next 6/8] net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC Salil Mehta
2017-07-23 16:53 ` Florian Fainelli
2017-07-27 17:56 ` Salil Mehta
2017-07-22 22:09 ` [PATCH V4 net-next 7/8] net: hns3: Add Ethtool support to HNS3 driver Salil Mehta
2017-07-23 17:05 ` Florian Fainelli
2017-07-24 20:32 ` Rustad, Mark D
2017-07-25 9:35 ` David Laight
2017-07-27 18:01 ` Salil Mehta
2017-07-27 18:04 ` Florian Fainelli
2017-07-27 20:46 ` Salil Mehta
2017-07-23 17:26 ` Stephen Hemminger
2017-07-27 15:53 ` Salil Mehta [this message]
2017-07-22 22:09 ` [PATCH V4 net-next 8/8] net: hns3: Add HNS3 driver to kernel build framework & MAINTAINERS Salil Mehta
2017-07-23 13:12 ` Leon Romanovsky
2017-07-27 15:56 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F4CC6FACFEB3C54C9141D49AD221F7F93B828136@FRAEML521-MBX.china.huawei.com \
--to=salil.mehta@huawei.com \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil.lnk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).