RE: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to VF driver

[Salil Mehta <salil.mehta@huawei.com>]

Hi Philippe,

> -----Original Message-----
> From: Philippe Ombredanne [mailto:pombredanne@nexb.com]
> Sent: Saturday, December 09, 2017 12:17 AM
> To: Salil Mehta <salil.mehta@huawei.com>
> Cc: David S. Miller <davem@davemloft.net>; Zhuangyuzeng (Yisen)
> <yisen.zhuang@huawei.com>; lipeng (Y) <lipeng321@huawei.com>;
> mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; LKML <linux-
> kernel@vger.kernel.org>; linux-rdma@vger.kernel.org; Linuxarm
> <linuxarm@huawei.com>
> Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add mailbox support to
> VF driver
> 
> Sali,

Sali ---> Salil

Thanks
> 
> On Fri, Dec 8, 2017 at 10:16 PM, Salil Mehta <salil.mehta@huawei.com>
> wrote:
> > This patch adds the support of the mailbox to the VF driver. The
> > mailbox shall be used as an interface to communicate with the
> > PF driver for various purposes like {set|get} MAC related
> > operations, reset, link status etc. The mailbox supports both
> > synchronous and asynchronous command send to PF driver.
> >
> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> > Signed-off-by: lipeng <lipeng321@huawei.com>
> [...]
> > --- /dev/null
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h
> > @@ -0,0 +1,94 @@
> > +/*
> > + * Copyright (c) 2016-2017 Hisilicon Limited.
> > + *
> > + * This program is free software; you can redistribute it and/or
> modify
> > + * it under the terms of the GNU General Public License as published
> by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> 
> Why not use the new SPDX ids?
We can. I will change the headers for files [.c .h Makefile] part of HNS3
VF driver change in next V3 patch submit.

> e.g.
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +/* Copyright (c) 2016-2017 Hisilicon Limited. */
> 
> See Linus posts and Thomas doc patches for details.
Sure.

Thanks!
> 
> --
> Cordially
> Philippe Ombredanne