From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756123AbbDOLco (ORCPT ); Wed, 15 Apr 2015 07:32:44 -0400 Received: from mga14.intel.com ([192.55.52.115]:39465 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754352AbbDOLch convert rfc822-to-8bit (ORCPT ); Wed, 15 Apr 2015 07:32:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,581,1422950400"; d="scan'208";a="714011398" From: "Kweh, Hock Leong" To: Greg Kroah-Hartman CC: Ming Lei , Matt Fleming , "Ong, Boon Leong" , LKML , "linux-efi@vger.kernel.org" , Sam Protsenko , Peter Jones , Andy Lutomirski , "Roy Franz" , Borislav Petkov Subject: RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware Thread-Topic: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware Thread-Index: AQHQdrzO9Y2+ZGg6U0KLDsR6juvZY51N4NhA Date: Wed, 15 Apr 2015 11:32:29 +0000 Message-ID: References: <1429004697-28320-1-git-send-email-hock.leong.kweh@intel.com> <1429004697-28320-3-git-send-email-hock.leong.kweh@intel.com> <20150414140914.GE5989@kroah.com> In-Reply-To: <20150414140914.GE5989@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > Sent: Tuesday, April 14, 2015 10:09 PM > > On Tue, Apr 14, 2015 at 05:44:56PM +0800, Kweh, Hock Leong wrote: > > From: "Kweh, Hock Leong" > > > > Introducing a kernel module to expose capsule loader interface > > for user to upload capsule binaries. This module leverage the > > request_firmware_direct_full_path() to obtain the binary at a > > specific path input by user. > > > > Example method to load the capsule binary: > > echo -n "/path/to/capsule/binary" > > /sys/devices/platform/efi_capsule_loader/capsule_loader > > Ick, why not just have the firmware file location present, and copy it > to the sysfs file directly from userspace, instead of this two-step > process? Err .... I may not catch your meaning correctly. Are you trying to say that you would prefer the user to perform: cat file.bin > /sys/.../capsule_loader instead of echo -n "/path/to/binary" > /sys/..../capsule_laoder The reason we stick with the firmware_class is because we don't want to replicate a code which already mature and has open API for developer to use. > > > +/* > > + * To remove this kernel module, just perform: > > + * rmmod efi_capsule_loader.ko > > This comment is not needed. Okay, I will remove this. > > > > + */ > > +static void __exit efi_capsule_loader_exit(void) > > +{ > > + platform_device_unregister(efi_capsule_pdev); > > This is not a platform device, don't abuse that interface please. > > greg k-h Okay, so you would recommend to use device_register() for this case? Or you would think that this is more suitable to use class_register()? Thanks & Regards, Wilson