From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"seraphin.bonnaffe@st.com" <seraphin.bonnaffe@st.com>,
"alexandre.torgue@gmail.com" <alexandre.torgue@gmail.com>,
"manabian@gmail.com" <manabian@gmail.com>,
"niklas.cassel@axis.com" <niklas.cassel@axis.com>,
"johan@kernel.org" <johan@kernel.org>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Voon, Weifeng" <weifeng.voon@intel.com>,
"lars.persson@axis.com" <lars.persson@axis.com>
Subject: RE: [PATCH] net: stmmac: synchronize stmmac_open and stmmac_dvr_probe
Date: Tue, 27 Dec 2016 05:26:43 +0000 [thread overview]
Message-ID: <F54AEECA5E2B9541821D670476DAE19C5A91691E@PGSMSX102.gar.corp.intel.com> (raw)
In-Reply-To: <20161226.235436.131087168899382517.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Tuesday, December 27, 2016 12:55 PM
> To: Kweh, Hock Leong <hock.leong.kweh@intel.com>
> Cc: Joao.Pinto@synopsys.com; peppe.cavallaro@st.com;
> seraphin.bonnaffe@st.com; alexandre.torgue@gmail.com;
> manabian@gmail.com; niklas.cassel@axis.com; johan@kernel.org;
> pavel@ucw.cz; Ong, Boon Leong <boon.leong.ong@intel.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Voon, Weifeng
> <weifeng.voon@intel.com>; lars.persson@axis.com
> Subject: Re: [PATCH] net: stmmac: synchronize stmmac_open and
> stmmac_dvr_probe
>
> From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> Date: Tue, 27 Dec 2016 19:44:59 +0800
>
> > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> >
> > If kernel module stmmac driver being loaded after OS booted, there is a
> > race condition between stmmac_open() and stmmac_mdio_register(), which is
> > invoked inside stmmac_dvr_probe(), and the error is showed in dmesg log as
> > PHY not found and stmmac_open() failed:
> ...
> > The resolution used wait_for_completion_interruptible() to synchronize
> > stmmac_open() and stmmac_dvr_probe() to prevent the race condition
> > happening.
> >
> > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
>
> The proper thing to do is to make sure register_netdevice() is not
> invoked until it is %100 safe to call stmmac_open().
Noted & thanks. Will look into it.
Regards,
Wilson
next prev parent reply other threads:[~2016-12-27 5:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 11:44 [PATCH] net: stmmac: synchronize stmmac_open and stmmac_dvr_probe Kweh, Hock Leong
2016-12-27 4:54 ` David Miller
2016-12-27 5:26 ` Kweh, Hock Leong [this message]
2016-12-27 5:10 ` Florian Fainelli
2016-12-27 5:13 ` Florian Fainelli
2016-12-27 5:25 ` Kweh, Hock Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F54AEECA5E2B9541821D670476DAE19C5A91691E@PGSMSX102.gar.corp.intel.com \
--to=hock.leong.kweh@intel.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@gmail.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=johan@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=pavel@ucw.cz \
--cc=peppe.cavallaro@st.com \
--cc=seraphin.bonnaffe@st.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).