From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752205AbcL2AdL (ORCPT ); Wed, 28 Dec 2016 19:33:11 -0500 Received: from mga02.intel.com ([134.134.136.20]:65454 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752080AbcL2AdE (ORCPT ); Wed, 28 Dec 2016 19:33:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,424,1477983600"; d="scan'208";a="916993134" From: "Kweh, Hock Leong" To: Florian Fainelli , David Miller CC: "Joao.Pinto@synopsys.com" , "peppe.cavallaro@st.com" , "seraphin.bonnaffe@st.com" , "alexandre.torgue@gmail.com" , "manabian@gmail.com" , "niklas.cassel@axis.com" , "johan@kernel.org" , "pavel@ucw.cz" , "Ong, Boon Leong" , "Voon, Weifeng" , "lars.persson@axis.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Thread-Topic: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and stmmac_dvr_probe Thread-Index: AQHSYAv4FCVbYJ2YS0yP58zd4NjMrqEbd9+AgAFVaICAAGDaAIAA5pKQ Date: Thu, 29 Dec 2016 00:28:59 +0000 Message-ID: References: <1482849756-21817-1-git-send-email-hock.leong.kweh@intel.com> <20161227.113405.362102687632949941.davem@davemloft.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uBT0XH1g020426 > -----Original Message----- > From: Florian Fainelli [mailto:f.fainelli@gmail.com] > Sent: Thursday, December 29, 2016 2:43 AM > To: Kweh, Hock Leong ; David Miller > > Cc: Joao.Pinto@synopsys.com; peppe.cavallaro@st.com; > seraphin.bonnaffe@st.com; alexandre.torgue@gmail.com; > manabian@gmail.com; niklas.cassel@axis.com; johan@kernel.org; > pavel@ucw.cz; Ong, Boon Leong ; Voon, Weifeng > ; lars.persson@axis.com; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize stmmac_open and > stmmac_dvr_probe > > On 12/27/2016 09:49 PM, Kweh, Hock Leong wrote: > >> -----Original Message----- > >> From: David Miller [mailto:davem@davemloft.net] > >> Sent: Wednesday, December 28, 2016 12:34 AM > >> To: Kweh, Hock Leong > >> Cc: Joao.Pinto@synopsys.com; peppe.cavallaro@st.com; > >> seraphin.bonnaffe@st.com; f.fainelli@gmail.com; > >> alexandre.torgue@gmail.com; manabian@gmail.com; > >> niklas.cassel@axis.com; johan@kernel.org; pavel@ucw.cz; Ong, Boon > >> Leong ; Voon, Weifeng > >> ; lars.persson@axis.com; > >> netdev@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: Re: [PATCH v2] net: stmmac: bug fix to synchronize > >> stmmac_open and stmmac_dvr_probe > >> > >> From: "Kweh, Hock Leong" > >> Date: Tue, 27 Dec 2016 22:42:36 +0800 > >> > >>> From: "Kweh, Hock Leong" > >> > >> You are not the author of this change, do not take credit for it. > >> > >> You have copied Florian's patch character by character, therefore he > >> is the author. > >> > >> You also didn't CC: the netdev mailing list properly. > > > > Hi David & Florian, > > > > Just to clarify that I do not copy exactly from Florian. > > I have changed it to have proper handling on mdio unregister while > > netdev_register() failed as showed below: > > > > return 0; > > > > -error_mdio_register: > > - unregister_netdev(ndev); > > error_netdev_register: > > + stmmac_mdio_unregister(ndev); > > Although this is required, we can't be doing it in all circumstances, we need to > mimic what stmmac_drv_remove() does. > > Let me submit an incremental fix which takes care of mdio bus unregistration. > -- > Florian Noted & Thanks. Will test it out once you submitted. Thanks & Regards, Wilson