Kconfig error: Missing dependency for MEMSTICK_UNSAFE_RESUME

Kconfig error: Missing dependency for MEMSTICK_UNSAFE_RESUME

[Sascha El-Sharkawy]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

Dear Kernel developers,

we detected a missing dependency inside the Kconfig model, which allows to configure Memstick support for power management (MEMSTICK_UNSAFE_RESUME) even if Power Management (PM) was disabled. We suggest to add a "depends on" constraint to the Kconfig model for semantical correctness and to simplify the configuration process by avoiding the configuration of unnecessary configuration options (patch is attached to this mail).
Without this dependency, a configuring user is not able to detect the divergence between the desired and real behavior of the kernel.
We also wrote a Bugzilla report for more details: https://bugzilla.kernel.org/show_bug.cgi?id=116871

Sincerely yours,
Sascha El-Sharkawy

-- -----------------------------------------------------------------------
Sascha El-Sharkawy, MSc 
University of Hildesheim                    Tel.: +49 (0) 5121 / 883-40336  
Institute of Computer Science               Fax:  +49 (0) 5121 / 883-40337
Universitaetsplatz 1                           elscha@sse.uni-hildesheim.de
D-31141 Hildesheim, Germany               http://www.sse.uni-hildesheim.de


[-- Attachment #2: MEMSTICK_UNSAFE_RESUME.patch --]
[-- Type: application/octet-stream, Size: 488 bytes --]

diff --git a/drivers/memstick/core/Kconfig b/drivers/memstick/core/Kconfig
index 1d38949..503e735 100644
--- a/drivers/memstick/core/Kconfig
+++ b/drivers/memstick/core/Kconfig
@@ -6,6 +6,7 @@ comment "MemoryStick drivers"
 
 config MEMSTICK_UNSAFE_RESUME
         bool "Allow unsafe resume (DANGEROUS)"
+        depends on PM
         help
           If you say Y here, the MemoryStick layer will assume that all
           cards stayed in their respective slots during the suspend. The