From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9C7C35254 for ; Mon, 17 Feb 2020 12:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4A8C20578 for ; Mon, 17 Feb 2020 12:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="QXjOmUMj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728661AbgBQMwH (ORCPT ); Mon, 17 Feb 2020 07:52:07 -0500 Received: from mo4-p02-ob.smtp.rzone.de ([81.169.146.168]:16702 "EHLO mo4-p02-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgBQMwH (ORCPT ); Mon, 17 Feb 2020 07:52:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1581943925; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=u71Pc6KAIo1SNLKuB56gx3LtEud7uCwwBJw8/xtQmEU=; b=QXjOmUMjjWI8ke4gN+RqEXRM7VroXh0o7DFspAwi9e3MJOLAMkRaxFFDEmrJpWa7+u Gbue9xQEeI6zcMG/OqMrTJdbEUe2UlxFZ+UhIUIikDWj5yeUZZT6pVWC/UJx+LzTymR4 m06s5cKFK8QgPtgbYNWd0zkJxzWEvYM6qaZqmhPTEwQjYRvxe/YuZPJm+zNtHX3GDqWZ pahXiyaeiEs7MBbJUZl0FY+BWsH+s2qMJ2VdI5TQ6Ksq1c9nk2341fdtrSTI+jK6FaTM NjSy9Gi63SS+8haBaCmDlfStFQxxf9cKsBbdZPukLwupadvuGy8cQwPfzVKKpVJCkfra UbRA== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDVCaXA0OXQ==" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 46.1.12 DYNA|AUTH) with ESMTPSA id U06217w1HCq2NEF (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Mon, 17 Feb 2020 13:52:02 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH v2] extcon: palmas: hide error messages if gpio returns -EPROBE_DEFER From: "H. Nikolaus Schaller" In-Reply-To: Date: Mon, 17 Feb 2020 13:52:01 +0100 Cc: linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-omap@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: MyungJoo Ham , Chanwoo Choi X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Am 17.02.2020 um 13:19 schrieb H. Nikolaus Schaller = : >=20 > If the gpios are probed after this driver (e.g. if they > come from an i2c expander) there is no need to print an > error message. >=20 > Signed-off-by: H. Nikolaus Schaller > --- > drivers/extcon/extcon-palmas.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/extcon/extcon-palmas.c = b/drivers/extcon/extcon-palmas.c > index edc5016f46f1..701d7c9584fa 100644 > --- a/drivers/extcon/extcon-palmas.c > +++ b/drivers/extcon/extcon-palmas.c > @@ -205,14 +205,18 @@ static int palmas_usb_probe(struct = platform_device *pdev) >=20 > palmas_usb->id_gpiod =3D devm_gpiod_get_optional(&pdev->dev, = "id", > GPIOD_IN); > - if (IS_ERR(palmas_usb->id_gpiod)) { > + if (PTR_ERR(palmas_usb->id_gpiod) !=3D -EPROBE_DEFER) { oops. Polarity went wrong. Will send a v3 asap. > + return -EPROBE_DEFER; > + } else if (IS_ERR(palmas_usb->id_gpiod)) { > dev_err(&pdev->dev, "failed to get id gpio\n"); > return PTR_ERR(palmas_usb->id_gpiod); > } >=20 > palmas_usb->vbus_gpiod =3D devm_gpiod_get_optional(&pdev->dev, = "vbus", > GPIOD_IN); > - if (IS_ERR(palmas_usb->vbus_gpiod)) { > + if (PTR_ERR(palmas_usb->vbus_gpiod) !=3D -EPROBE_DEFER) { > + return -EPROBE_DEFER; > + } else if (IS_ERR(palmas_usb->vbus_gpiod)) { > dev_err(&pdev->dev, "failed to get vbus gpio\n"); > return PTR_ERR(palmas_usb->vbus_gpiod); > } > --=20 > 2.23.0 >=20