From: "岩松信洋 / IWAMATSU,NOBUHIRO" <nobuhiro.iwamatsu.kw@hitachi.com>
To: Kees Cook <keescook@chromium.org>
Cc: "Anton Vorontsov" <anton@enomsg.org>,
"Colin Cross" <ccross@android.com>,
"Tony Luck" <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"Mark Salyzyn" <salyzyn@android.com>,
"阿口誠司 / AGUCHI,SEIJI" <seiji.aguchi.tr@hitachi.com>,
"Shuah Khan" <shuahkh@osg.samsung.com>
Subject: RE: [PATCH v2 5/5] selftests/pstore: add testcases for multiple pmsg instances
Date: Wed, 5 Oct 2016 04:14:14 +0000 [thread overview]
Message-ID: <F89ECF87BC754A49BB74E794F6A0EC2FF6827A@GSjpTKYDCembx31.service.hitachi.net> (raw)
In-Reply-To: <CAGXu5jJFR5zXB7RkTD9-nX9xE_=G6ZfPNt30AT-WS=RzvNq6kw@mail.gmail.com>
Hi,
> -----Original Message-----
> From: keescook@google.com [mailto:keescook@google.com] On Behalf Of Kees
> Cook
> Sent: Friday, September 09, 2016 6:56 AM
> To: 岩松信洋 / IWAMATSU,NOBUHIRO
> Cc: Anton Vorontsov; Colin Cross; Tony Luck; LKML; Hiraku Toyooka; Mark
> Salyzyn; 阿口誠司 / AGUCHI,SEIJI; Shuah Khan
> Subject: Re: [PATCH v2 5/5] selftests/pstore: add testcases for multiple
> pmsg instances
>
> On Sun, Jul 24, 2016 at 8:56 PM, Nobuhiro Iwamatsu
> <nobuhiro.iwamatsu.kw@hitachi.com> wrote:
> > From: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> >
> > To test multiple pmsg, we should check that /dev/pmsg[N] (N > 0) is
> > available. After reboot, we should check that pmsg-[backend]-[N] which
> > keeps content is detected even if pmsg-[backend]-[N-M] (0 < M <= N)
> > doesn't exist due to lack of contents.
> >
> > So this adds the following testcases.
> > - pstore_tests
> > - Write unique string to the last /dev/pmsgN
> > - pstore_post_reboot_tests
> > - Check the last pmsg area is detected
> >
> > Signed-off-by: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com>
> > Cc: Mark Salyzyn <salyzyn@android.com>
> > Cc: Seiji Aguchi <seiji.aguchi.tr@hitachi.com>
> > Cc: Shuah Khan <shuahkh@osg.samsung.com>
> > ---
> > tools/testing/selftests/pstore/common_tests | 21
> +++++++++++++++--
> > .../selftests/pstore/pstore_post_reboot_tests | 27
> ++++++++++++----------
> > tools/testing/selftests/pstore/pstore_tests | 16
> ++++++++++---
> > 3 files changed, 47 insertions(+), 17 deletions(-)
> >
> > diff --git a/tools/testing/selftests/pstore/common_tests
> > b/tools/testing/selftests/pstore/common_tests
> > index 3ea64d7..566a25d 100755
> > --- a/tools/testing/selftests/pstore/common_tests
> > +++ b/tools/testing/selftests/pstore/common_tests
<snip>
> > +last_devpmsg=`ls -v /dev/pmsg* | tail -n1` prlog -n "Writing unique
> > +string to the last /dev/pmsgN "
> > +if [ "$last_devpmsg" = "/dev/pmsg0" ]; then
> > + prlog "... No multiple /dev/pmsg* exists. We skip this testcase."
> > +else
> > + prlog -n "(${last_devpmsg}) ... "
> > + echo "${TEST_STRING_PATTERN}""$UUID" > ${last_devpmsg}
> > + show_result $?
> > +
>
> Blank line here can be dropped.
>
> > +fi
> > +
> > exit $rc
> > --
> > 2.8.1
> >
> >
>
> Otherwise, this looks good. Thanks!
>
OK, I will fix these.
And thanks again for review this patch series.
> -Kees
>
> --
> Kees Cook
> Nexus Security
Best regards,
Nobuhiro
prev parent reply other threads:[~2016-10-05 4:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 3:56 [PATCH v2 0/5] pstore: ramoops: support multiple pmsg instances Nobuhiro Iwamatsu
2016-07-25 3:56 ` [PATCH v2 1/5] ramoops: use persistent_ram_free() instead of kfree() for freeing prz Nobuhiro Iwamatsu
2016-07-28 19:35 ` Kees Cook
2016-07-29 5:58 ` 岩松信洋 / IWAMATSU,NOBUHIRO
2016-08-03 19:04 ` Kees Cook
2016-07-25 3:56 ` [PATCH v2 2/5] ramoops: introduce generic init/free functions for prz Nobuhiro Iwamatsu
2016-09-08 21:22 ` Kees Cook
2016-10-05 4:06 ` 岩松信洋 / IWAMATSU,NOBUHIRO
2016-07-25 3:56 ` [PATCH v2 3/5] pstore: support multiple pmsg instances Nobuhiro Iwamatsu
2016-09-08 21:33 ` Kees Cook
2016-10-05 4:09 ` 岩松信洋 / IWAMATSU,NOBUHIRO
2016-07-25 3:56 ` [PATCH v2 4/5] ramoops: " Nobuhiro Iwamatsu
2016-09-08 21:53 ` Kees Cook
2016-10-05 4:13 ` 岩松信洋 / IWAMATSU,NOBUHIRO
2016-07-25 3:56 ` [PATCH v2 5/5] selftests/pstore: add testcases for " Nobuhiro Iwamatsu
2016-09-08 21:55 ` Kees Cook
2016-10-05 4:14 ` 岩松信洋 / IWAMATSU,NOBUHIRO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F89ECF87BC754A49BB74E794F6A0EC2FF6827A@GSjpTKYDCembx31.service.hitachi.net \
--to=nobuhiro.iwamatsu.kw@hitachi.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salyzyn@android.com \
--cc=seiji.aguchi.tr@hitachi.com \
--cc=shuahkh@osg.samsung.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).