From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbcHHGFM (ORCPT ); Mon, 8 Aug 2016 02:05:12 -0400 Received: from exsmtp02.microchip.com ([198.175.253.38]:60511 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750801AbcHHGFL (ORCPT ); Mon, 8 Aug 2016 02:05:11 -0400 From: To: , CC: , , , , , , , , , , , Subject: RE: [PATCH v3 7/7] doc: bindings: act8945a-charger: Update properties Thread-Topic: [PATCH v3 7/7] doc: bindings: act8945a-charger: Update properties Thread-Index: AQHR6TpKnQSzn3fc5kyHHuNDWPkVJqAwZn8AgA47coA= Date: Mon, 8 Aug 2016 06:05:09 +0000 Message-ID: References: <1469755528-8413-1-git-send-email-wenyou.yang@atmel.com> <1469755528-8413-8-git-send-email-wenyou.yang@atmel.com> <20160729214020.GA18140@rob-hp-laptop> In-Reply-To: <20160729214020.GA18140@rob-hp-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.76.4] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7865HGd017500 Hi Rob, > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 2016Äê7ÔÂ30ÈÕ 5:40 > To: Wenyou Yang > Cc: Sebastian Reichel ; Dmitry Eremin-Solenikov > ; David Woodhouse ; Pawel > Moll ; Mark Brown ; Ian Campbell > ; Kumar Gala ; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; Nicolas Ferre ; linux- > pm@vger.kernel.org > Subject: Re: [PATCH v3 7/7] doc: bindings: act8945a-charger: Update properties > > On Fri, Jul 29, 2016 at 09:25:28AM +0800, Wenyou Yang wrote: > > Due the driver improvements, update the properties, > > - Remove "active-semi,check-battery-temperature" property. > > - Add the properties, "active-semi,irq_gpio" > > and "active-semi,lbo-gpios". > > > > Signed-off-by: Wenyou Yang > > --- > > > > Changes in v3: None > > Changes in v2: None > > > > Documentation/devicetree/bindings/power/act8945a-charger.txt | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt > b/Documentation/devicetree/bindings/power/act8945a-charger.txt > > index bea254c..d7cf05b 100644 > > --- a/Documentation/devicetree/bindings/power/act8945a-charger.txt > > +++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt > > @@ -4,10 +4,12 @@ Required properties: > > - compatible: "active-semi,act8945a", please refer to ../mfd/act8945a.txt. > > - active-semi,chglev-gpios: charge current level phandle with args > > as described in ../gpio/gpio.txt. > > + - active-semi,irq_gpios: specify the charger interrupt input phanle > > + with args as as described in ../gpio/gpio.txt. > > As I said in v2, this should be an interrupt property instead. Sorry for forgetting to change. Accepted, will be in next version. Thanks. > > > + - active-semi,lbo-gpios: specify the low battery voltage detect phandle > > + with args as as described in ../gpio/gpio.txt. > > Maybe this one too. The capacity level function need to read this pin level, so this one should not use "interrupts" property. > > > > > Optional properties: > > - - active-semi,check-battery-temperature: boolean to check the battery > > - temperature or not. > > - active-semi,input-voltage-threshold-microvolt: unit: mV; > > Specifies the charger's input over-voltage threshold value; > > The value can be: 6600, 7000, 7500, 8000; default: 6600 > > -- > > 2.7.4 > > Best Regards, Wenyou Yang