From: Marcel Holtmann <marcel@holtmann.org>
To: pharish <pharish@codeaurora.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org,
bgodavar@codeaurora.org, rjliao@codeaurora.org,
hbandi@codeaurora.org, abhishekpandit@chromium.org,
mcchou@chromium.org, saluvala@codeaurora.org
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Optimizations in init sequence for WCN6750.
Date: Thu, 25 Nov 2021 19:44:41 +0100 [thread overview]
Message-ID: <FA830939-AD92-47D0-A125-3543B89D7E2D@holtmann.org> (raw)
In-Reply-To: <1637846230-4798-1-git-send-email-pharish@codeaurora.org>
Hi,
> This change adds optimazation in init sequence for WCN6750.
you need to explain what you are doing.
>
> Signed-off-by: pharish <pharish@codeaurora.org>
> ---
> drivers/bluetooth/hci_qca.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 6f44b26..4dedaaa 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1603,15 +1603,19 @@ static int qca_regulator_init(struct hci_uart *hu)
> */
> qcadev = serdev_device_get_drvdata(hu->serdev);
> if (!qcadev->bt_power->vregs_on) {
> - serdev_device_close(hu->serdev);
> + if (qca_is_wcn399x(soc_type))
> + serdev_device_close(hu->serdev);
> +
> ret = qca_regulator_enable(qcadev);
> if (ret)
> return ret;
>
> - ret = serdev_device_open(hu->serdev);
> - if (ret) {
> - bt_dev_err(hu->hdev, "failed to open port");
> - return ret;
> + if (qca_is_wcn399x(soc_type)) {
> + ret = serdev_device_open(hu->serdev);
> + if (ret) {
> + bt_dev_err(hu->hdev, "failed to open port");
> + return ret;
> + }
I am really not doing this. You need to stop doing this SoC X or SoC Y crap. I said this before and I am saying this again, start from scratch and write a clean serdev only driver. Adding things to hci_qca is just a hack.
> }
> }
>
> @@ -1635,9 +1639,8 @@ static int qca_regulator_init(struct hci_uart *hu)
> }
> }
>
> - qca_set_speed(hu, QCA_INIT_SPEED);
> -
> if (qca_is_wcn399x(soc_type)) {
> + qca_set_speed(hu, QCA_INIT_SPEED);
> ret = qca_send_power_pulse(hu, true);
> if (ret)
> return ret;
> @@ -1648,6 +1651,7 @@ static int qca_regulator_init(struct hci_uart *hu)
> * Without this, we will have RTS and CTS synchronization
> * issues.
> */
> +
Unrelated change.
> serdev_device_close(hu->serdev);
> ret = serdev_device_open(hu->serdev);
> if (ret) {
Regards
Marcel
prev parent reply other threads:[~2021-11-25 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 13:17 [PATCH v1] Bluetooth: hci_qca: Optimizations in init sequence for WCN6750 pharish
2021-11-25 13:17 ` [PATCH v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF pharish
2021-11-25 18:42 ` Marcel Holtmann
2021-12-07 5:39 ` pharish
2021-11-25 18:44 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FA830939-AD92-47D0-A125-3543B89D7E2D@holtmann.org \
--to=marcel@holtmann.org \
--cc=abhishekpandit@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcchou@chromium.org \
--cc=mka@chromium.org \
--cc=pharish@codeaurora.org \
--cc=rjliao@codeaurora.org \
--cc=saluvala@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).