From: "Ong, Hean Loong" <hean.loong.ong@intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>,
"Thayer, Thor" <thor.thayer@intel.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"See, Chin Liang" <chin.liang.see@intel.com>
Subject: RE: [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for blinking leds
Date: Tue, 2 Jul 2019 00:31:32 +0000 [thread overview]
Message-ID: <FB1B748C9B55D647AEE382CBB370D20F46F6E600@PGSMSX109.gar.corp.intel.com> (raw)
In-Reply-To: <722335f6-1c39-5f1e-d5f5-8aa32626dc6c@kernel.org>
Thank you Dinh
Best Regards,
Hean Loong
Internal Global Dial: 2 701 6773
Direct Line: +60 4 636 6773
>-----Original Message-----
>From: Dinh Nguyen <dinguyen@kernel.org>
>Sent: Monday, July 1, 2019 11:55 PM
>To: Ong, Hean Loong <hean.loong.ong@intel.com>; Thayer, Thor
><thor.thayer@intel.com>
>Cc: linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; See,
>Chin Liang <chin.liang.see@intel.com>
>Subject: Re: [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for
>blinking leds
>
>
>
>On 6/27/19 9:07 AM, Ong, Hean Loong wrote:
>> Adding LED Triggers Timers for LED blinking support on ARM devices
>>
>> Signed-off-by: Ong, Hean Loong <hean.loong.ong@intel.com>
>> ---
>> arch/arm64/configs/defconfig | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/configs/defconfig
>> b/arch/arm64/configs/defconfig index 4d58351..6fbd651 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -595,6 +595,7 @@ CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>> CONFIG_LEDS_TRIGGER_CPU=y CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
>> CONFIG_LEDS_TRIGGER_PANIC=y
>> +CONFIG_LEDS_TRIGGER_TIMER=y
>> CONFIG_EDAC=y
>> CONFIG_EDAC_GHES=y
>> CONFIG_RTC_CLASS=y
>>
>
>I've applied this patch with this change:
>
>--- a/arch/arm64/configs/defconfig
>+++ b/arch/arm64/configs/defconfig
>@@ -590,6 +590,7 @@ CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_GPIO=y
> CONFIG_LEDS_PWM=y
> CONFIG_LEDS_SYSCON=y
>+CONFIG_LEDS_TRIGGER_TIMER=y
> CONFIG_LEDS_TRIGGER_DISK=y defconfig
> CONFIG_LEDS_TRIGGER_HEARTBEAT=y
> CONFIG_LEDS_TRIGGER_CPU=y
>
>Also, the commit header should be "arm64: defconfig".
>
>Dinh
prev parent reply other threads:[~2019-07-02 0:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 14:07 [PATCHv1] ARM64: defconfig: Adding LEDS_TRIGGERS_TIMER Ong, Hean Loong
2019-06-27 14:07 ` [PATCHv1] ARM64: defconfig: Add LEDS_TRIGGERS_TIMER for blinking leds Ong, Hean Loong
2019-07-01 15:54 ` Dinh Nguyen
2019-07-02 0:31 ` Ong, Hean Loong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FB1B748C9B55D647AEE382CBB370D20F46F6E600@PGSMSX109.gar.corp.intel.com \
--to=hean.loong.ong@intel.com \
--cc=chin.liang.see@intel.com \
--cc=dinguyen@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thor.thayer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).