From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031828AbbKDXBm (ORCPT ); Wed, 4 Nov 2015 18:01:42 -0500 Received: from mga09.intel.com ([134.134.136.24]:4104 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031562AbbKDXBj convert rfc822-to-8bit (ORCPT ); Wed, 4 Nov 2015 18:01:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,245,1444719600"; d="scan'208";a="842796956" From: "Nelson, Shannon" To: Sowmini Varadhan , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: "Kirsher, Jeffrey T" , "Brandeburg, Jesse" , "Wyborny, Carolyn" , "Skidmore, Donald C" , "Vick, Matthew" , "Ronciak, John" , "Williams, Mitch A" , "andy.shevchenko@gmail.com" Subject: RE: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM Thread-Topic: [PATCH v5] i40e: Look up MAC address in Open Firmware or IDPROM Thread-Index: AQHRFzilmsYd62C5H0SlFEjh28JEqZ6MdjEA Date: Wed, 4 Nov 2015 23:01:37 +0000 Message-ID: References: <20151104193956.GD14575@oracle.com> In-Reply-To: <20151104193956.GD14575@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Sowmini Varadhan [mailto:sowmini.varadhan@oracle.com] > Sent: Wednesday, November 04, 2015 11:40 AM > > > This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC > address in Open Firmware or IDPROM"). > > As with that fix, attempt to look up the MAC address in Open Firmware > on systems that support it, and use IDPROM on SPARC if no OF address > is found. > > In the case of the i40e there is an assumption that the default mac > address has already been set up as the primary mac filter on probe, > so if this filter is obtained from the Open Firmware or IDPROM, an > explicit write is needed via i40e_aq_mac_address_write() and > i40e_aq_add_macvlan() invocation. > > Reviewed-by: Martin K. Petersen > Signed-off-by: Sowmini Varadhan > --- > v2, v3: Andy Shevchenko comments > v4: Shannon Nelson review: explicitly set up mac filters before > register_netdev > v5: Shannon Nelson code style comments > > drivers/net/ethernet/intel/i40e/i40e_main.c | 84 > ++++++++++++++++++++++++++- > 1 files changed, 83 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c > b/drivers/net/ethernet/intel/i40e/i40e_main.c > index b825f97..a3883cf 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -24,6 +24,15 @@ > * > > ************************************************************************** > ****/ > > +#include > +#include > +#include > + > +#ifdef CONFIG_SPARC > +#include > +#include > +#endif > + > /* Local includes */ > #include "i40e.h" > #include "i40e_diag.h" > @@ -9213,6 +9222,44 @@ static struct i40e_vsi > *i40e_vsi_reinit_setup(struct i40e_vsi *vsi) > } > > /** > + * i40e_macaddr_init - explicitly write the mac address filters. This > + * is needed when the macaddr has been obtained by other means than > + * the default, e.g., from Open Firmware or IDPROM. Note that this should be a simple single line, function name and short summary; anything more detailed goes into a description after the variables. [...] > > /** > + * i40e_get_platform_mac_addr - get mac address from Open Firmware > + * or IDPROM if supported by the platform Again, single line. Thanks for your work on this, Sowmini. If you can do a quick repost with these little function header comment bits tweaked, I'm willing to ACK this patch and I think we'll be ready for Jeff to include it into his tree. sln