From: Jens Axboe <axboe@kernel.dk>
To: "André Almeida" <andrealmeid@collabora.com>
Cc: linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, corbet@lwn.net,
kernel@collabora.com, krisman@collabora.com
Subject: Re: [PATCH 0/4] null_blk: fixes around nr_devices and log improvements
Date: Fri, 13 Sep 2019 12:03:34 -0700 [thread overview]
Message-ID: <FFDFD18F-C242-46D2-B64B-5515987AD82D@kernel.dk> (raw)
In-Reply-To: <20190913185746.337429-1-andrealmeid@collabora.com>
On Sep 13, 2019, at 11:58 AM, André Almeida <andrealmeid@collabora.com> wrote:
>
> Hello,
>
> This patch series address feedback for a previous patch series sent by
> me "docs: block: null_blk: enhance document style"[1].
>
> First patch removes a restriction that prevents null_blk to load with
> (nr_devices == 0). This restriction breaks applications, so it's a bug. I
> have tested it running the kernel with `null_blk.nr_devices=0`.
>
> In the previous series I have changed the type of var nr_devices, but I
> forgot to change the type at module_param(). The second patch fix that.
>
> The third patch uses a cleaver approach to make log messages consistent
> using pr_fmt and the last one add a note on how to do that at the
> coding style documentation.
Please add Fixes tags to your patches.
next prev parent reply other threads:[~2019-09-13 19:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 18:57 [PATCH 0/4] null_blk: fixes around nr_devices and log improvements André Almeida
2019-09-13 18:57 ` [PATCH 1/4] null_blk: do not fail the module load with zero devices André Almeida
2019-09-13 18:57 ` [PATCH 2/4] null_blk: match the type of parameter nr_devices André Almeida
2019-09-13 18:57 ` [PATCH 3/4] null_blk: format pr_* logs with pr_fmt André Almeida
2019-09-13 20:18 ` Chaitanya Kulkarni
2019-09-13 18:57 ` [PATCH 4/4] coding-style: add explanation about pr_fmt macro André Almeida
2019-09-13 19:08 ` Joe Perches
2019-09-13 19:36 ` André Almeida
2019-09-13 20:22 ` Bart Van Assche
2019-09-14 7:08 ` Jonathan Corbet
2019-09-13 19:03 ` Jens Axboe [this message]
2019-09-13 19:22 ` [PATCH 0/4] null_blk: fixes around nr_devices and log improvements André Almeida
2019-09-13 20:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFDFD18F-C242-46D2-B64B-5515987AD82D@kernel.dk \
--to=axboe@kernel.dk \
--cc=andrealmeid@collabora.com \
--cc=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).