From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Bhupesh Sharma <bhsharma@redhat.com>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"jlee@suse.com" <jlee@suse.com>, Borislav Petkov <bp@alien8.de>,
"Luck, Tony" <tony.luck@intel.com>,
"luto@kernel.org" <luto@kernel.org>,
"mst@redhat.com" <mst@redhat.com>,
"Neri, Ricardo" <ricardo.neri@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: RE: [PATCH V2 0/3] Use mm_struct and switch_mm() instead of manually
Date: Sun, 3 Sep 2017 07:46:16 +0000 [thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F1859E218@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <CACi5LpOTjBbT7ngiQykTbhUbVoODvxQRj5Ub-fm7yMP8VySkpA@mail.gmail.com>
> >
> > Thanks for this v2.
> > Introducing the 'efi_switch_mm() ' helper instead of manually
> > twiddling with %cr3 seems more cleaner.
> >
> > I have tested this patchset on a x86_64 machine with the following
> > configurations:
> >
> > 1. Primary kernel boot with efi=old_map 2. Primary kernel boot with
> > new efi map
> >
> > While it seems that efi=old_map passes, the new efi map boot fails for
> > me on both the two x86 machine (Dell 3050MT and a SGI - UV300 machine.
> >
> > It seems we are hitting a NULL pointer deference in
> > 'efi_call_phys_prolog' while accessing '&efi_mm'.
> >
> > Please see the log below for details:
> >
> > [ 0.020006] BUG: unable to handle kernel NULL pointer dereference
> > at (null)
> > [ 0.021000] IP: switch_mm_irqs_off+0x44/0x270
> > [ 0.021000] Call Trace:
> > [ 0.021000] switch_mm+0x20/0x30
> > [ 0.021000] efi_switch_mm+0x49/0x60
> > [ 0.021000] efi_call_phys_prolog+0x56/0x1b3
> > [ 0.021000] efi_enter_virtual_mode+0x3a9/0x520
> > [ 0.021000] start_kernel+0x424/0x4c8
> > [ 0.021000] ? set_init_arg+0x5a/0x5a
> > [ 0.021000] ? early_idt_handler_array+0x120/0x120
> > [ 0.021000] x86_64_start_reservations+0x29/0x2b
> > [ 0.021000] x86_64_start_kernel+0x151/0x174
> > [ 0.021000] secondary_startup_64+0x9f/0x9f
> > [ 0.021000] Code: 2d 82 51 d9 4f 65 c7 05 0f 65 da 4f 01 00 00 00
> > 48 39 f7 0f 84 14 01 00 00 65 48 89 35 f6 64 da 4f 48 8b 86 e8 02 00
> > 00 45 89 ed <f0> 4c 0f ab 28 bf 00 00 00 80 48 03 7e 50 48 8b 05 27 b0
> > b9 00
> > [ 0.021000] RIP: switch_mm_irqs_off+0x44/0x270 RSP: ffffffffb0e035d0
> > [ 0.021000] CR2: 0000000000000000
> > [ 0.021000] ---[ end trace fb94349305e1cb8b ]---
> > [ 0.021000] Kernel panic - not syncing: Fatal exception
> > [ 0.021000] ---[ end Kernel panic - not syncing: Fatal exception
> >
>
> And I forgot to mention that I tried the patchset both with the efi/next and
> linus's trees and saw the same result.
>
> I would be happy to help in case you need further details of the test environment
> or need help in testing this crash further.
>
> Regards,
> Bhupesh
Hi Bhupesh,
Thanks for trying the patches and raising the concern.
Could you also please also give a try on qemu? (if reproducible, we will be having a common platform to start debugging)
I have tested this patch set on qemu and real machines (different from one's you tried) in our lab and didn’t notice this issue.
Regards,
Sai
next prev parent reply other threads:[~2017-09-03 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 23:37 [PATCH V2 0/3] Use mm_struct and switch_mm() instead of manually Sai Praneeth Prakhya
2017-08-28 23:37 ` [PATCH V2 1/3] efi: Use efi_mm in x86 as well as ARM Sai Praneeth Prakhya
2017-08-28 23:37 ` [PATCH V2 2/3] x86/efi: Replace efi_pgd with efi_mm.pgd Sai Praneeth Prakhya
2017-08-28 23:37 ` [PATCH V2 3/3] x86/efi: Use efi_switch_mm() rather than manually twiddling with %cr3 Sai Praneeth Prakhya
2017-09-02 14:08 ` [PATCH V2 0/3] Use mm_struct and switch_mm() instead of manually Bhupesh Sharma
2017-09-02 14:23 ` Bhupesh Sharma
2017-09-03 7:46 ` Prakhya, Sai Praneeth [this message]
2017-09-05 7:43 ` Bhupesh Sharma
2017-09-06 2:21 ` Sai Praneeth Prakhya
2017-09-06 2:43 ` Sai Praneeth Prakhya
2017-09-06 9:00 ` Prakhya, Sai Praneeth
2017-09-08 11:55 ` Bhupesh Sharma
2017-09-11 7:10 ` Prakhya, Sai Praneeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FFF73D592F13FD46B8700F0A279B802F1859E218@ORSMSX114.amr.corp.intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhsharma@redhat.com \
--cc=bp@alien8.de \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mst@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).