From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S937649AbdLSGX5 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 01:23:57 -0500
Received: from mga11.intel.com ([192.55.52.93]:33560 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933584AbdLSGXx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 01:23:53 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,425,1508828400"; 
   d="scan'208";a="4001059"
From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Bhupesh Sharma <bhsharma@redhat.com>
CC: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Lee, Chun-Yi" <jlee@suse.com>, Borislav Petkov <bp@alien8.de>,
        "Luck, Tony" <tony.luck@intel.com>, Andy Lutomirski <luto@kernel.org>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        "Neri, Ricardo" <ricardo.neri@intel.com>,
        "Matt Fleming" <matt@codeblueprint.co.uk>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: RE: [PATCH 0/3] Use mm_struct and switch_mm() instead of manually
Thread-Topic: [PATCH 0/3] Use mm_struct and switch_mm() instead of manually
Thread-Index: AQHTdsuEcTdPOSdewkSX1Z4ys4vhUaNIj0uAgAGmafA=
Date: Tue, 19 Dec 2017 06:23:51 +0000
Message-ID: <FFF73D592F13FD46B8700F0A279B802F2E3F763C@ORSMSX114.amr.corp.intel.com>
References: <1513469158-5638-1-git-send-email-sai.praneeth.prakhya@intel.com>
 <CACi5LpOHm_xWodv6qd+b9nk1ivpZyR9rvicmR3UgvxuLSRmuew@mail.gmail.com>
In-Reply-To: <CACi5LpOHm_xWodv6qd+b9nk1ivpZyR9rvicmR3UgvxuLSRmuew@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmY3MjllOGEtY2U5Yi00MGRlLThiZDItNmMxMGQ2ZjIyOGVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJrNkRwb1RkOTNvR2VLQkQ0TklWR0h4cHVXNVZMVWlGTzVKcnRVWDJRaWhxMERNQUI4bUxObndQOUZqK0hwcnRPIn0=
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [10.22.254.140]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vBJ6O1vH027822

> > Changes in V3:
> > 1. When CPUMASK_OFFSTACK is enabled, switch_mm_irqs_off() sets cpumask
> > by calling cpumask_set_cpu(). This panics kernel as efi_mm is not
> > initialized, therefore initialize efi_mm in efi_alloc_page_tables().
> 
> Thanks for the v3.
> 
> I confirmed that the issue I saw with the v2 when I enabled 'efi=debug' on the
> sgi-uv 300 machine (i.e the NULL pointer access while accessing
> mm_cpumask(next), in the function call
> 'switch_mm_irqs_off') is fixed in the v3.
> 
> Also as I noted during the v2 review, introducing the 'efi_switch_mm() ' helper
> instead of manually twiddling with %cr3 seems more cleaner (having personally
> debugged this leg several times on the underlying x86 EFI machines).
> 
> So in addition to me testing this on the sgi-uv300 and Dell Optiplex EFI enabled
> machine, please feel free to add:
> 
> Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
> 

Hi  Bhupesh,

Thanks for the review and re-iterating the usefulness of this patch set.

Regards,
Sai