RE: [tip:efi/core] x86/efi: Unmap EFI boot services code/data regions from efi_pgd

From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
To: Ingo Molnar <mingo@kernel.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"x86@kernel.org" <x86@kernel.org>
Cc: "bp@alien8.de" <bp@alien8.de>,
	"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
	"eric.snowberg@oracle.com" <eric.snowberg@oracle.com>,
	"hdegoede@redhat.com" <hdegoede@redhat.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>,
	"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>,
	"julien.thierry@arm.com" <julien.thierry@arm.com>,
	"bhsharma@redhat.com" <bhsharma@redhat.com>,
	"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
	"joe@perches.com" <joe@perches.com>,
	"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"natechancellor@gmail.com" <natechancellor@gmail.com>,
	"luto@kernel.org" <luto@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sedat.dilek@gmail.com" <sedat.dilek@gmail.com>,
	"zhuyifei1999@gmail.com" <zhuyifei1999@gmail.com>,
	"linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>
Subject: RE: [tip:efi/core] x86/efi: Unmap EFI boot services code/data regions from efi_pgd
Date: Mon, 17 Dec 2018 18:06:54 +0000	[thread overview]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F48604575@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <tip-08cfb38f3ef49cfd1bba11a00401451606477d80@git.kernel.org>

> Commit-ID:  08cfb38f3ef49cfd1bba11a00401451606477d80
> Gitweb:
> https://git.kernel.org/tip/08cfb38f3ef49cfd1bba11a00401451606477d80
> Author:     Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
> AuthorDate: Thu, 29 Nov 2018 18:12:24 +0100
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Fri, 30 Nov 2018 09:10:30 +0100
> 
> x86/efi: Unmap EFI boot services code/data regions from efi_pgd
> 
> efi_free_boot_services(), as the name suggests, frees EFI boot services
> code/data regions but forgets to unmap these regions from efi_pgd. This means
> that any code that's running in efi_pgd address space (e.g:
> any EFI runtime service) would still be able to access these regions but the
> contents of these regions would have long been over written by someone else.
> So, it's important to unmap these regions. Hence, introduce efi_unmap_pages()
> to unmap these regions from efi_pgd.
> 
> After unmapping EFI boot services code/data regions, any illegal access by
> buggy firmware to these regions would result in page fault which will be handled
> by EFI specific fault handler.

Hi Thomas and Ingo,

I recently noticed that the below commits [1] and [2] are broken when kernel command line 
argument "efi=old_map" is passed. Sorry! I missed to test this condition prior to sending 
these patches to mailing list. I am working on a fix and will send it to mailing list as 
soon as it's ready.

Meanwhile, could you please drop these patches before sending pull request to Linus?

[1] Commit 08cfb38f3ef4 ("x86/efi: Unmap EFI boot services code/data regions from efi_pgd")
[2] Commit 7e0dabd3010d ("x86/mm/pageattr: Introduce helper function to unmap EFI boot services")

Regards,
Sai