From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,HK_RANDOM_REPLYTO,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE41DC433E0 for ; Sun, 5 Jul 2020 02:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 989F220782 for ; Sun, 5 Jul 2020 02:48:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="DRV+xQmi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728198AbgGECs0 (ORCPT ); Sat, 4 Jul 2020 22:48:26 -0400 Received: from mail-40135.protonmail.ch ([185.70.40.135]:45801 "EHLO mail-40135.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728004AbgGECsZ (ORCPT ); Sat, 4 Jul 2020 22:48:25 -0400 Date: Sun, 05 Jul 2020 02:48:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1593917302; bh=pmMW5RuvGxW1tpO1VhOI282KLL4Jyl1FTQA9xHHkje0=; h=Date:To:From:Reply-To:Subject:From; b=DRV+xQmisuiAsx1+Yha2dlCbDHytWWCnUPz0BqGWq+248/rATeQ+YR+wM2wyy+cVb coT2B9en+mgxOKUFdNKenoVW4CKQ9Q3czSpS/uCksg5QtgTMck0Tl4IY8Wn5LesWeC vY4tfGQgEokDWfOLTibNNYo8ByXWON5Ex4KcpnRs= To: "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jikos@kernel.org" , Benjamin Tissoires From: Mazin Rezk Reply-To: Mazin Rezk Subject: [PATCH] HID: logitech: Use HIDPP_RECEIVER_INDEX instead of 0xff Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some parts of hid-logitech-dj explicitly referred to 0xff for the receiver index. This patch changes those references to the HIDPP_RECEIVER_INDEX definition. Signed-off-by: Mazin Rezk --- drivers/hid/hid-logitech-dj.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c index 48dff5d6b605..a78c13cc9f47 100644 --- a/drivers/hid/hid-logitech-dj.c +++ b/drivers/hid/hid-logitech-dj.c @@ -1153,7 +1153,7 @@ static int logi_dj_recv_query_paired_devices(struct d= j_receiver_dev *djrcv_dev) =09if (!dj_report) =09=09return -ENOMEM; =09dj_report->report_id =3D REPORT_ID_DJ_SHORT; -=09dj_report->device_index =3D 0xFF; +=09dj_report->device_index =3D HIDPP_RECEIVER_INDEX; =09dj_report->report_type =3D REPORT_TYPE_CMD_GET_PAIRED_DEVICES; =09retval =3D logi_dj_recv_send_report(djrcv_dev, dj_report); =09kfree(dj_report); @@ -1175,7 +1175,7 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_r= eceiver_dev *djrcv_dev, =09if (djrcv_dev->type =3D=3D recvr_type_dj) { =09=09dj_report->report_id =3D REPORT_ID_DJ_SHORT; -=09=09dj_report->device_index =3D 0xFF; +=09=09dj_report->device_index =3D HIDPP_RECEIVER_INDEX; =09=09dj_report->report_type =3D REPORT_TYPE_CMD_SWITCH; =09=09dj_report->report_params[CMD_SWITCH_PARAM_DEVBITFIELD] =3D 0x3F; =09=09dj_report->report_params[CMD_SWITCH_PARAM_TIMEOUT_SECONDS] =3D @@ -1204,7 +1204,7 @@ static int logi_dj_recv_switch_to_dj_mode(struct dj_r= eceiver_dev *djrcv_dev, =09memset(buf, 0, HIDPP_REPORT_SHORT_LENGTH); =09buf[0] =3D REPORT_ID_HIDPP_SHORT; -=09buf[1] =3D 0xFF; +=09buf[1] =3D HIDPP_RECEIVER_INDEX; =09buf[2] =3D 0x80; =09buf[3] =3D 0x00; =09buf[4] =3D 0x00; -- 2.27.0