From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 383BDC43331 for ; Mon, 30 Mar 2020 16:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F18EB20780 for ; Mon, 30 Mar 2020 16:41:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="G/ImTS88" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729415AbgC3QlU (ORCPT ); Mon, 30 Mar 2020 12:41:20 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:53590 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726497AbgC3QlU (ORCPT ); Mon, 30 Mar 2020 12:41:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1585586476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rQAjpeP0ttna+M7acg2Qd2oZ1ja9i8Cn7x068Tgta1w=; b=G/ImTS8808q+pnxeBUdAY668zG/YSSC3Fbif0jFMowpr/KK3vToUvBogUe8tLsGR3OfNAd 7Vg7p2w5OQT44xLd0onL4f7NRr0Bs3jaqK6kqduYRCJ4kBsjZv2tqVL68JqxHMHfGUE713 GJ2wkAfqyIaxDFxztQQ5apUF0k1jQ7I= Date: Mon, 30 Mar 2020 18:41:04 +0200 From: Paul Cercueil Subject: Re: [PATCH v4 3/4] pwm: jz4740: Obtain regmap from parent node To: Thierry Reding Cc: Uwe =?iso-8859-1?q?Kleine-K=F6nig?= , od@zcrc.me, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Mathieu Malaterre , Artur Rojek Message-Id: In-Reply-To: <20200330143716.GI2431644@ulmo> References: <20200323142421.42817-1-paul@crapouillou.net> <20200323142421.42817-3-paul@crapouillou.net> <20200330143716.GI2431644@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, Le lun. 30 mars 2020 =E0 16:37, Thierry Reding=20 a =E9crit : > On Mon, Mar 23, 2020 at 03:24:20PM +0100, Paul Cercueil wrote: > [...] >> diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm/pwm-jz4740.c > [...] >> @@ -196,12 +208,19 @@ static const struct pwm_ops jz4740_pwm_ops =3D { >> static int jz4740_pwm_probe(struct platform_device *pdev) >> { >> struct jz4740_pwm_chip *jz4740; >> + struct device *dev =3D &pdev->dev; >>=20 >> - jz4740 =3D devm_kzalloc(&pdev->dev, sizeof(*jz4740), GFP_KERNEL); >> + jz4740 =3D devm_kzalloc(dev, sizeof(*jz4740), GFP_KERNEL); >> if (!jz4740) >> return -ENOMEM; >>=20 >> - jz4740->chip.dev =3D &pdev->dev; >> + jz4740->map =3D device_node_to_regmap(dev->parent->of_node); >> + if (!jz4740->map) { >=20 > This seems wrong. According to the code, device_node_to_regmap()=20 > returns > an ERR_PTR()-encoded error code on failure, so I think this should be: >=20 > if (IS_ERR(jz4740->map)) { > ... > return PTR_ERR(jz4740->map); > } >=20 > No need to resend for that, I can take care of that when applying. Let > me know if that doesn't work. Yes, that works for me. Good catch. Thanks, -Paul >=20 > Thierry