From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817AbcEZISi (ORCPT ); Thu, 26 May 2016 04:18:38 -0400 Received: from mail-am1on0070.outbound.protection.outlook.com ([157.56.112.70]:27376 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750776AbcEZISe convert rfc822-to-8bit (ORCPT ); Thu, 26 May 2016 04:18:34 -0400 From: Meng Yi To: Alexander Stein CC: Stefan Agner , "dri-devel@lists.freedesktop.org" , David Airlie , "airlied@redhat.com" , "linux-kernel@vger.kernel.org" , Mark Brown Subject: RE: fsl-dcu not works on latest "drm-next" Thread-Topic: fsl-dcu not works on latest "drm-next" Thread-Index: AdGlFm3AneZxjhLuSCG3KXnHNBlzPgREwk9wAAkAXQAABJ/mgAAAcsMAAAKDjwAAAB9OgAAEvAwAACmUB8A= Date: Thu, 26 May 2016 08:18:30 +0000 Message-ID: References: <2162860.ovvuqaWfeW@ws-stein> <8051435.bV5T0CxpSc@ws-stein> In-Reply-To: <8051435.bV5T0CxpSc@ws-stein> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: systec-electronic.com; dkim=none (message not signed) header.d=none;systec-electronic.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [192.158.241.86] x-ms-office365-filtering-correlation-id: c79d9cb7-1e01-4b19-3230-08d3853e52de x-microsoft-exchange-diagnostics: 1;HE1PR04MB1052;5:iC/H5bGQYjdPB17U2ZJvDVKpzq4lJvVkRZtLiBTT32Ih2UAVwVpgRP9TvS9f08B/ZJ5LR4YLT0zLUoQRJu2r1cZSu1t8t9wEPdI4OUw91zOxGVwsC0BjhZ2NuCBIX68kydJZEAYZjXGTeByHb2dClw==;24:efVUk7E2o77XcCA55sAoQjXMwZn+hRwK92eCVeW6jvY2DVvHKCQUHz7lYAbP5s8iiuMWuWko0iLOg5NwlhCZ8DJOAoZSne53iXvxP4Iadzs=;7:kV7GimMk8b3z4GPU1FMCmZN0lLGVbBPyJqtegoLlqdUA7juVyYNN2i2NQunFP8rRRw1S0IT/SfjfUIDu2xY6HB9r4RdS/nOTScEX7PWjP2Lpl+4lB+oMeSUsJn/x9evf6zXY3avxzfL3OFGTSvqVGPtBZPb8pbsoZOBARtQNlPyzmJahYtPNMUa/4ck+fBt7 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1052; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:HE1PR04MB1052;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1052; x-forefront-prvs: 0954EE4910 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(50986999)(76576001)(8936002)(76176999)(11100500001)(81166006)(54356999)(110136002)(5008740100001)(189998001)(8676002)(10400500002)(33656002)(87936001)(5003600100002)(9686002)(93886004)(5004730100002)(66066001)(2906002)(77096005)(86362001)(122556002)(2950100001)(586003)(3280700002)(4326007)(92566002)(3660700001)(19580405001)(6116002)(102836003)(74316001)(3846002)(2900100001)(5002640100001)(575784001)(1220700001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR04MB1052;H:HE1PR04MB1051.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2016 08:18:31.0385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1052 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexander, > From your backtrace I guess wait_event_timeout is called in some atomic > context (might_sleep(); is called inside wait_event_timeout). This has nothing > to do with regmap. > Here is my view of point: Since IRQ setup codes using regmap, and which is not setup properly, so wait_event_timeout. > > The inital problem came up with 922a9f936e40001f9b921379aab90047d5990923 > ("regmap: mmio: Convert to regmap_bus and fix accessor usage"). The > commits 9f9f8b863ad130ec0c25f378bdbad64ba71291de, > 4f7d6dd4df8b388e2056c89b528254cdd79dea2a and > 0dbdb76c0ca8e7caf27c9a210f64c4359e2974a4 tried to fix that. With those I > could successfully probe DCU. Thanks for your information. DCU was able to be probed without those patches, and DCU still not works with those patches. And here is my DTS and regmap_config, Specified "big-endian" in DTS, dcu: dcu@2ce0000 { compatible = "fsl,ls1021a-dcu"; reg = <0x0 0x2ce0000 0x0 0x10000>; interrupts = ; clocks = <&platform_clk 0>; clock-names = "dcu"; big-endian; status = "disabled"; }; I can't tell the difference of "reg_format_endian" and " val_format_endian ", so I had tried four conditions. static const struct regmap_config fsl_dcu_regmap_config = { .reg_bits = 32, .reg_stride = 4, .val_bits = 32, .cache_type = REGCACHE_RBTREE, // .reg_format_endian = REGMAP_ENDIAN_BIG, // .val_format_endian = REGMAP_ENDIAN_BIG, .volatile_reg = fsl_dcu_drm_is_volatile_reg, }; Thanks, Best Regards, Meng Yi