[PATCH] Drivers: hv: vmbus: Disallow the freeze PM operation

* [PATCH] Drivers: hv: vmbus: Disallow the freeze PM operation
@ 2020-04-07 22:01 Dexuan Cui
  2020-04-08 15:47 ` Vitaly Kuznetsov
  0 siblings, 1 reply; 5+ messages in thread
From: Dexuan Cui @ 2020-04-07 22:01 UTC (permalink / raw)
  To: kys, haiyangz, sthemmin, wei.liu, linux-hyperv, linux-kernel,
	mikelley, vkuznets
  Cc: Dexuan Cui

Before the hibernation patchset (e.g. f53335e3289f), a Linux VM on Hyper-V
can run "echo freeze > /sys/power/state" (or "systemctl suspend")
to freeze the system. The user can press the keyboard or move the mouse
to wake up the VM. Note: the two aforementioned commands are equivalent
here, because Hyper-V doesn't support the guest ACPI S3 state.

With the hibernation patchset, a Linux VM on Hyper-V can hibernate to disk
and resume back; however, the 'freeze' operation is broken for Hyper-V
Generation-2 VM (which doesn't have a legacy keyboard/mouse): when the
vmbus devices are suspended, the VM can not receive any interrupt from
the synthetic keyboard/mouse devices, so there is no way to wake up the
VM. This is not an issue for Generaton-1 VM, because it looks the legacy
keyboard/mouse devices can still be used to wake up the VM in my test.

IMO 'freeze' in a Linux VM on Hyper-V is not really useful in practice,
so let's disallow the operation for both Gen-1 and Gen-2 VMs, even if
it's not an issue for Gen-1 VMs.

Fixes: f53335e3289f ("Drivers: hv: vmbus: Suspend/resume the vmbus itself for hibernation")
Signed-off-by: Dexuan Cui <decui@microsoft.com>
---
 drivers/hv/vmbus_drv.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 029378c..82a4327 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -28,6 +28,7 @@
 #include <linux/notifier.h>
 #include <linux/ptrace.h>
 #include <linux/screen_info.h>
+#include <linux/suspend.h>
 #include <linux/kdebug.h>
 #include <linux/efi.h>
 #include <linux/random.h>
@@ -2357,6 +2358,23 @@ static void hv_synic_resume(void)
 	.resume = hv_synic_resume,
 };
 
+/*
+ * Note: "freeze/suspend" here means "systemctl suspend".
+ * "systemctl hibernate" is still supported.
+ */
+static int hv_pm_notify(struct notifier_block *nb,
+			unsigned long val, void *ign)
+{
+	if (val == PM_SUSPEND_PREPARE) {
+		pr_info("freeze/suspend is not supported\n");
+		return NOTIFY_BAD;
+	}
+
+	return NOTIFY_DONE;
+}
+
+static struct notifier_block hv_pm_nb;
+
 static int __init hv_acpi_init(void)
 {
 	int ret, t;
@@ -2389,6 +2407,8 @@ static int __init hv_acpi_init(void)
 	hv_setup_crash_handler(hv_crash_handler);
 
 	register_syscore_ops(&hv_synic_syscore_ops);
+	hv_pm_nb.notifier_call = hv_pm_notify;
+	register_pm_notifier(&hv_pm_nb);
 
 	return 0;
 
@@ -2402,6 +2422,7 @@ static void __exit vmbus_exit(void)
 {
 	int cpu;
 
+	unregister_pm_notifier(&hv_pm_nb);
 	unregister_syscore_ops(&hv_synic_syscore_ops);
 
 	hv_remove_kexec_handler();
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread