From: Huaisheng HS1 Ye <firstname.lastname@example.org> To: Matthew Wilcox <email@example.com> Cc: "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, NingTing Cheng <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org> Subject: RE: [External] Re: [PATCH v1] include/linux/gfp.h: getting rid of GFP_ZONE_TABLE/BAD Date: Wed, 16 May 2018 12:12:00 +0000 [thread overview] Message-ID: <HK2PR03MB1684A881A868E9676C7E55E692920@HK2PR03MB1684.apcprd03.prod.outlook.com> (raw) In-Reply-To: <20180512142249.GA24215@bombadil.infradead.org> > From: Matthew Wilcox [mailto:email@example.com] > Sent: Saturday, May 12, 2018 10:23 PM> > On Sat, May 12, 2018 at 11:35:00AM +0000, Huaisheng HS1 Ye wrote: > > > The point of this exercise is to actually encode the zone number in > > > the bottom bits of the GFP flags instead of something which has to be > > > interpreted into a zone number. When somebody sets __GFP_MOVABLE, they > > > should also be setting ZONE_MOVABLE: > > > > > > -#define __GFP_MOVABLE ((__force gfp_t)___GFP_MOVABLE) /* ZONE_MOVABLE allowed > */ > > > +#define __GFP_MOVABLE ((__force gfp_t)(___GFP_MOVABLE | (ZONE_MOVABLE ^ > ZONE_NORMAL))) > > > > > I am afraid we couldn't do that, because __GFP_MOVABLE would be used potentially > with other __GFPs like __GFP_DMA and __GFP_DMA32. > > That's not a combination that makes much sense. I know it's permitted today > (and it has the effect of being a no-op), but when you think about it, it > doesn't actually make any sense. Yes, you are right. After checking almost all references of __GFP_MOVABLE and other __GFP_* flags, perhaps I was far to get excessive pursuit of logical correctness. For those nonsense combinations, I should ignore them. Current GFP_ZONE_TABLE can ensure all logical correctness. That makes me want to pursue same effect. Next, I will revise the patch according to your advice, then try to get overall testing result as far as possible. There are many combinations because of a lot of conditions in file system and drivers. Hope I could test all things related to the lower 4 bits of gfp. Sincerely, Huaisheng Ye
next prev parent reply other threads:[~2018-05-16 12:12 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <firstname.lastname@example.org> 2018-05-10 16:30 ` Matthew Wilcox 2018-05-11 3:24 ` [External] " Huaisheng HS1 Ye 2018-05-11 13:26 ` Matthew Wilcox 2018-05-12 11:35 ` Huaisheng HS1 Ye 2018-05-12 14:22 ` Matthew Wilcox 2018-05-16 12:12 ` Huaisheng HS1 Ye [this message] 2018-05-18 3:03 ` Huaisheng HS1 Ye
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=HK2PR03MB1684A881A868E9676C7E55E692920@HK2PR03MB1684.apcprd03.prod.outlook.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='RE: [External] Re: [PATCH v1] include/linux/gfp.h: getting rid of GFP_ZONE_TABLE/BAD' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).