From: "Yuezhang.Mo@sony.com" <Yuezhang.Mo@sony.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: "sj1557.seo@samsung.com" <sj1557.seo@samsung.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Andy.Wu@sony.com" <Andy.Wu@sony.com>,
"Wataru.Aoyama@sony.com" <Wataru.Aoyama@sony.com>,
"Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp"
<Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Subject: RE: [PATCH] exfat: do not clear VolumeDirty in writeback
Date: Tue, 8 Mar 2022 10:55:28 +0000 [thread overview]
Message-ID: <HK2PR04MB38910EE3467822EBAB4CC79681099@HK2PR04MB3891.apcprd04.prod.outlook.com> (raw)
In-Reply-To: <CAKYAXd_hF+xYXNiawCZLYmnha+wSUSUCEJTVBw8v6UDYfjPiUg@mail.gmail.com>
Hi Namjae Jeon,
> > +int exfat_clear_volume_dirty(struct super_block *sb) {
> > + if (sb->s_flags & (SB_SYNCHRONOUS | SB_DIRSYNC))
> How about moving exfat_clear_volume_dirty() to IS_DIRSYNC() check in each
> operations instead of this check?
I found that VolumeDirty keeps VOL_DIRTY until sync or umount regardless of sync or dirsync enabled,
because there is no paired call to exfat_set_volume_dirty()/exfat_clear_volume_dirty() in __exfat_write_inode().
If exfat_set_volume_dirty()/exfat_clear_volume_dirty() is called in pairs in __exfat_write_inode(),
it will cause frequent writing of bootsector.
So, how about removing exfat_clear_volume_dirty() from each operations, except in exfat_sync_fs()?
Best Regards,
Yuezhang Mo
next prev parent reply other threads:[~2022-03-08 10:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 5:18 [PATCH] exfat: do not clear VolumeDirty in writeback Yuezhang.Mo
2022-02-08 6:43 ` Yuezhang.Mo
2022-02-28 3:24 ` Yuezhang.Mo
2022-03-01 9:19 ` Namjae Jeon
2022-02-28 7:11 ` Kohada.Tetsuhiro
2022-02-28 10:51 ` Yuezhang.Mo
2022-03-02 9:29 ` Kohada.Tetsuhiro
2022-03-03 7:08 ` Yuezhang.Mo
2022-03-07 5:34 ` Kohada.Tetsuhiro
2022-03-05 6:03 ` Namjae Jeon
2022-03-08 10:55 ` Yuezhang.Mo [this message]
2022-03-09 11:14 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK2PR04MB38910EE3467822EBAB4CC79681099@HK2PR04MB3891.apcprd04.prod.outlook.com \
--to=yuezhang.mo@sony.com \
--cc=Andy.Wu@sony.com \
--cc=Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp \
--cc=Wataru.Aoyama@sony.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).