From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbcKHCRc (ORCPT ); Mon, 7 Nov 2016 21:17:32 -0500 Received: from relmlor4.renesas.com ([210.160.252.174]:51160 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752254AbcKHCRa (ORCPT ); Mon, 7 Nov 2016 21:17:30 -0500 X-IronPort-AV: E=Sophos;i="5.31,608,1473087600"; d="scan'208";a="224754157" From: Yoshihiro Shimoda To: Nicholas Mc Guire , Greg Kroah-Hartman CC: Felipe Balbi , Julia Lawall , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] usb: renesas_usbhs: simplify list handling Thread-Topic: [PATCH] usb: renesas_usbhs: simplify list handling Thread-Index: AQHSOSoJdElkC2VYhkqVgB6AepsDfaDOVyog Date: Tue, 8 Nov 2016 02:17:25 +0000 Message-ID: References: <1478545622-29591-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1478545622-29591-1-git-send-email-hofrat@osadl.org> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.144] x-ms-office365-filtering-correlation-id: 785c8927-b58a-4795-b68a-08d4077d6187 x-microsoft-exchange-diagnostics: 1;HK2PR06MB0546;7:S2hY/Zek8CUjSsrne8COP6uudICJTnJSmjT6a/aeLWrVStirsL9yK+VGz1qwYK0KJYH05/+4F5xtkrRUftAunHQPGBKXYB+J7GAaXNrN0vJRgCM6W651px+IhPSghMPc+dTNT5PP0qJ3Q4oKoUs3BWGUB95jU9G1vJ/7UYQW5LJRS5BEMeCkGHUk0QSn8lZFDr4M05bkLyTgtwwxHtBJ2lhcbT5D6ffDki35ljyswqw2pSGxvQ+knuaI+BiFga63oBTEXut45OgScizpqzoOcm08jiS8vevC3eVZdEIhW+zN0LWDkl/CefHJMP2ODWY86GWMPdajzjlxbqSN8E94a3s+dP8NCt+xlN09iz7KCCI=;20:zFuwNMWPQTyvrUJSlM5EP9lfmWbDlVye4vVXoybU3L4qxcYN9YTaK/tCIt/LIe1Rl4eHdSn7E8+kM/wh3mF3s//b+P7al6rvkU/ZTaU3fHk+AS9b6/d/pi4V5ORIX9o27z3NkCMeHXPis5ytBVnU1BSBfrqt5R6ovYsFmdbCEoY= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HK2PR06MB0546; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(84791874153150); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:HK2PR06MB0546;BCL:0;PCL:0;RULEID:;SRVR:HK2PR06MB0546; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(199003)(189002)(377454003)(76176999)(122556002)(8676002)(50986999)(54356999)(105586002)(7736002)(7846002)(8936002)(81166006)(81156014)(4326007)(2950100002)(7696004)(6116002)(5660300001)(106116001)(106356001)(305945005)(77096005)(74316002)(2900100001)(345774005)(33656002)(101416001)(3846002)(3280700002)(92566002)(66066001)(102836003)(87936001)(586003)(76576001)(189998001)(86362001)(2906002)(5001770100001)(68736007)(9686002)(97736004)(3660700001)(575784001);DIR:OUT;SFP:1102;SCL:1;SRVR:HK2PR06MB0546;H:HK2PR06MB0548.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2016 02:17:25.3351 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR06MB0546 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uA82Hu3Z004033 Hi, > From: Nicholas Mc Guire > Sent: Tuesday, November 08, 2016 4:07 AM > > The current code is effectively equivalent to list_first_entry_or_null() > so simply switch and simplify the code. > > Fixes: 6acb95d4e070 ("usb: renesas_usbhs: modify packet queue control method") > Signed-off-by: Nicholas Mc Guire > --- > Found by simple coccinelle scanner > > Compile tested with: multi_v7_defconfig (implies > CONFIG_USB_RENESAS_USBHS=m) > > Patch is against 4.9.0-rc2 (localversion-next is next-20161028) Thank you for the patch! However, such a patch is already merged in the Felipe's usb.git repository unfortunately... https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=31faf878bd8c7e2c078a3b75f65efe64f23b0f18 So, the patch will appear in linux-next repository in the future. Best regards, Yoshihiro Shimoda