From: Kuo-Hsiang Chou <kuohsiang_chou@aspeedtech.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "airlied@redhat.com" <airlied@redhat.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
Jenmin Yuan <jenmin_yuan@aspeedtech.com>,
Arc Sung <arc_sung@aspeedtech.com>,
Tommy Huang <tommy_huang@aspeedtech.com>
Subject: RE: [PATCH] drm/ast: Create chip AST2600
Date: Tue, 10 Nov 2020 03:33:22 +0000 [thread overview]
Message-ID: <HK2PR06MB33003C10AA74ABE7FD8697628CE90@HK2PR06MB3300.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <fd2cdee4-3eb3-facd-5398-56d74fa7cf14@suse.de>
Hi, Thomas,
OK, I will describe the patch more precisely in the future. Thanks again!!!
Have a good day.
Kuo-Hsiang Chou
-----Original Message-----
From: Thomas Zimmermann [mailto:tzimmermann@suse.de]
Sent: Monday, November 09, 2020 6:26 PM
To: Kuo-Hsiang Chou <kuohsiang_chou@aspeedtech.com>; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Cc: airlied@redhat.com; airlied@linux.ie; daniel@ffwll.ch; Jenmin Yuan <jenmin_yuan@aspeedtech.com>; Arc Sung <arc_sung@aspeedtech.com>; Tommy Huang <tommy_huang@aspeedtech.com>
Subject: Re: [PATCH] drm/ast: Create chip AST2600
Hi
Am 09.11.20 um 10:38 schrieb KuoHsiang Chou:
> [New] Support AST2600
A style issue: better write a nice sentence than these tags. For the patch at hand, I'd preferred something like: "Only add an id for supporting AST2600. No functional changes are required."
I assume that there areno further changes required for AST2600.
>
> Signed-off-by: KuoHsiang Chou <kuohsiang_chou@aspeedtech.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
I'll add the patch to drm-misc-next. Thanks!
Best regards
Thomas
> ---
> drivers/gpu/drm/ast/ast_drv.h | 1 +
> drivers/gpu/drm/ast/ast_main.c | 5 ++++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_drv.h
> b/drivers/gpu/drm/ast/ast_drv.h index 467049ca8430..6b9e3b94a712
> 100644
> --- a/drivers/gpu/drm/ast/ast_drv.h
> +++ b/drivers/gpu/drm/ast/ast_drv.h
> @@ -63,6 +63,7 @@ enum ast_chip {
> AST2300,
> AST2400,
> AST2500,
> + AST2600,
> };
>
> enum ast_tx_chip {
> diff --git a/drivers/gpu/drm/ast/ast_main.c
> b/drivers/gpu/drm/ast/ast_main.c index 77066bca8793..4ec6884f6c65
> 100644
> --- a/drivers/gpu/drm/ast/ast_main.c
> +++ b/drivers/gpu/drm/ast/ast_main.c
> @@ -143,7 +143,10 @@ static int ast_detect_chip(struct drm_device *dev, bool *need_post)
> ast_detect_config_mode(dev, &scu_rev);
>
> /* Identify chipset */
> - if (dev->pdev->revision >= 0x40) {
> + if (dev->pdev->revision >= 0x50) {
> + ast->chip = AST2600;
> + drm_info(dev, "AST 2600 detected\n");
> + } else if (dev->pdev->revision >= 0x40) {
> ast->chip = AST2500;
> drm_info(dev, "AST 2500 detected\n");
> } else if (dev->pdev->revision >= 0x30) {
> --
> 2.18.4
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
prev parent reply other threads:[~2020-11-10 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:38 [PATCH] drm/ast: Create chip AST2600 KuoHsiang Chou
2020-11-09 10:26 ` Thomas Zimmermann
2020-11-10 3:33 ` Kuo-Hsiang Chou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK2PR06MB33003C10AA74ABE7FD8697628CE90@HK2PR06MB3300.apcprd06.prod.outlook.com \
--to=kuohsiang_chou@aspeedtech.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=arc_sung@aspeedtech.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jenmin_yuan@aspeedtech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tommy_huang@aspeedtech.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).