From: Paul Cercueil <paul@crapouillou.net>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: zboot: head.S clean up
Date: Mon, 21 Dec 2020 14:09:53 +0000 [thread overview]
Message-ID: <HO0PLQ.1VZP0U76MARY1@crapouillou.net> (raw)
In-Reply-To: <20201221130048.7753-1-jiaxun.yang@flygoat.com>
Hi Jiaxun,
Le lun. 21 déc. 2020 à 21:00, Jiaxun Yang <jiaxun.yang@flygoat.com> a
écrit :
> .cprestore is removed as we don't except Position Independent
> zboot ELF.
>
> .noreorder is also removed and rest instructions is massaged
> to improve readability.
>
> t9 register is used to indirect jump as MIPS ABI requirement.
>
> Reported-by: Paul Cercueil <paul@crapouillou.net>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> arch/mips/boot/compressed/head.S | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/arch/mips/boot/compressed/head.S
> b/arch/mips/boot/compressed/head.S
> index 409cb483a9ff..977218c90bc8 100644
> --- a/arch/mips/boot/compressed/head.S
> +++ b/arch/mips/boot/compressed/head.S
> @@ -15,8 +15,6 @@
> #include <asm/asm.h>
> #include <asm/regdef.h>
>
> - .set noreorder
> - .cprestore
> LEAF(start)
> start:
You can also remove the 'start' label, since it's declared inside the
LEAF() macro as well. GNU's assembler won't mind, but LLVM will choke
on that.
Cheers,
-Paul
> /* Save boot rom start args */
> @@ -35,21 +33,20 @@ start:
> PTR_LA a0, (.heap) /* heap address */
> PTR_LA sp, (.stack + 8192) /* stack address */
>
> - PTR_LA ra, 2f
> - PTR_LA k0, decompress_kernel
> - jr k0
> - nop
> + PTR_LA t9, decompress_kernel
> + jalr t9
> +
> 2:
> move a0, s0
> move a1, s1
> move a2, s2
> move a3, s3
> - PTR_LI k0, KERNEL_ENTRY
> - jr k0
> - nop
> + PTR_LI t9, KERNEL_ENTRY
> + jalr t9
> +
> 3:
> b 3b
> - nop
> +
> END(start)
>
> .comm .heap,BOOT_HEAP_SIZE,4
> --
> 2.29.2
>
next prev parent reply other threads:[~2020-12-21 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 13:00 [PATCH] MIPS: zboot: head.S clean up Jiaxun Yang
2020-12-21 14:09 ` Paul Cercueil [this message]
2020-12-21 14:18 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HO0PLQ.1VZP0U76MARY1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).