From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF27BC43333 for ; Tue, 19 Jan 2021 10:39:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 846E32312E for ; Tue, 19 Jan 2021 10:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390677AbhASKan (ORCPT ); Tue, 19 Jan 2021 05:30:43 -0500 Received: from mail-40136.protonmail.ch ([185.70.40.136]:33166 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390022AbhASKTS (ORCPT ); Tue, 19 Jan 2021 05:19:18 -0500 Date: Tue, 19 Jan 2021 10:18:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1611051513; bh=q+dny+d9bvN1Z30lIJh9zYFbNAX8RL+E2yHDrPen8dc=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=EEJJJiPIPVks4KgMcNX6viXtSMfYjtON2y4W70FpTyTi14JE/rViukoIbCoh/NwXN hS2y3D1bjc6lPimCVxpsJGSayd2xTHqIPYkw+u2PNQdJZGb4Ts6i0V0kinGewOOUKB oBAMay6gJFo6aUuzcfDMK+QfOwnHlqdJ+tcouH/UU4s7dbOdAFtGrHpPbrCtmEiLVr Uh2CHjzBIq/6E7dwbs5d92IPTrVY1/ye8B23nwyLheIdxzxKsSNI/011eJlJ3J6yIg gEdyJ1b35Ic670vTqrTU2L79iCZcVqEYXS/RsIj7UFODx29LjbOHcEuOjkhOp7NBYg OdkXmaVJ2dDfA== To: Lyude Paul From: Simon Ser Cc: nouveau@lists.freedesktop.org, James Jones , Martin Peres , Jeremy Cline , stable@vger.kernel.org, Ben Skeggs , David Airlie , Daniel Vetter , =?utf-8?Q?Christian_K=C3=B6nig?= , Thomas Zimmermann , Nirmoy Das , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Reply-To: Simon Ser Subject: Re: [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Message-ID: In-Reply-To: <20210119015415.2511028-1-lyude@redhat.com> References: <20210119015415.2511028-1-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul wr= ote: > Nvidia hardware doesn't actually support using tiling formats with the > cursor plane, only linear is allowed. In the future, we should write a > testcase for this. > > Fixes: c586f30bf74c ("drm/nouveau/kms: Add format mod prop to base/ovly/n= vdisp") > Cc: James Jones > Cc: Martin Peres > Cc: Jeremy Cline > Cc: Simon Ser > Cc: # v5.8+ > Signed-off-by: Lyude Paul Together with [1], this patch allows me to run unpatched modifier-aware user-space successfully, without a cursor visual glitch. drm_info correctly reports the new modifier list, and wlroots logs confirm that a flavor of NVIDIA_BLOCK_LINEAR_2D is used for the primary buffers and LINEAR is used for cursor buffers. Code looks good to me as well. Reviewed-by: Simon Ser [1]: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3724