From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E34C3C433F5 for ; Fri, 14 Jan 2022 15:42:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242614AbiANPm6 (ORCPT ); Fri, 14 Jan 2022 10:42:58 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:59659 "EHLO mail-4323.proton.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbiANPm5 (ORCPT ); Fri, 14 Jan 2022 10:42:57 -0500 Date: Fri, 14 Jan 2022 15:42:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail; t=1642174975; bh=EDKmMDpJ4aF8Jp9f8mriWffkkG6VIvSJs4wR/AP+ggA=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=m5aL4UXJkpjG0FRD9uFetuEs+xpH+kXIMKqxUSkXtD9HMRy8geRSGttKTRj9N6qHf sUfn1Sip08X5dbDnVeC3bHDbv0dIsUXfFMs70iR6N1s+DPNEQCS1S1IPJny7HNDnz0 CbgAp5WmoKrU2W2dF20PQYvmFTHaYgx9S+o4NP/suE1AAOnoZ5la2zx3F1sjzzBIYL mNTPnhJK7tzj0E6324hNyzhxEnE42IUE6Y2ORoHzfZs0zze3CVghcaxDAiDfrtt38M K442F2rVZkm8DcV0ikY1XLCz3MMuc5av/OizhUhgJRh2Lm/6RcHyIWgMiniuxCcIz5 ZqRULRIgThSXg== To: Andy Shevchenko From: Simon Ser Cc: Tomohito Esaki , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Ben Skeggs , =?utf-8?Q?Michel_D=C3=A4nzer?= , Qingqing Zhuo , Bas Nieuwenhuizen , Mark Yacoub , Sean Paul , Evan Quan , Petr Mladek , Sakari Ailus , Lee Jones , Abhinav Kumar , Dmitry Baryshkov , Rob Clark , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, Daniel Stone , Laurent Pinchart , Damian Hobson-Garcia , Takanari Hayama Reply-To: Simon Ser Subject: Re: [RFC PATCH v3 2/3] drm: add support modifiers for drivers whose planes only support linear layout Message-ID: In-Reply-To: References: <20220114101753.24996-1-etom@igel.co.jp> <20220114101753.24996-3-etom@igel.co.jp> <7eljcd3F4aWL2jjBRwr3DISmyt0XPWFIH1_kebFGqZTJXLZRx0bm_8c8yaIuEuH8rS0MaJhU6SY1y-fc6U_zCLaKgoLM124nZpr0H91nSjw=@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, January 14th, 2022 at 16:17, Andy Shevchenko wrote: > On Fri, Jan 14, 2022 at 03:07:21PM +0000, Simon Ser wrote: > > On Friday, January 14th, 2022 at 15:16, Andy Shevchenko wrote: > > > > > Why not enum? > > > > There is no enum for DRM format modifiers. > > I'm not sure how this prevents to use enum in the code instead of const u= 64. > Any specific reason for that? I'm not sure how one would use an enum as the array item type, when there i= s no defined enum type. Moreover, all the rest of DRM uses uint64 for modifiers.