From: "Christer Nilsson" <christer.nilsson@kretskompaniet.se>
To: "Greg KH" <greg@kroah.com>, <lepied@xfree86.org>
Cc: "Linux-Kernel" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] 2.4.19-pre8 Fix for Intuos tablet in wacom.c
Date: Tue, 14 May 2002 20:56:14 +0200 [thread overview]
Message-ID: <IBEJLIFNGHPKEKCKODPDMEDODPAA.christer.nilsson@kretskompaniet.se> (raw)
In-Reply-To: <20020514153735.GB18532@kroah.com>
Hi Frederic.
Can you take a look at this?
I've looked at the code at
http://people.mandrakesoft.com/~flepied/projects/wacom/ and found that
there's a couple of lines missing in the kernel driver. It seems that a
smoothing algorithm is left out
in the kernel source. My patch just circumvents that.
Christer Nilsson
> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Tuesday, May 14, 2002 5:38 PM
> To: Christer Nilsson; lepied@xfree86.org
> Cc: Linux-Kernel
> Subject: Re: [PATCH] 2.4.19-pre8 Fix for Intuos tablet in wacom.c
>
>
> On Tue, May 14, 2002 at 10:31:45AM +0200, Christer Nilsson wrote:
> >
> > The changes between 2.4.19-pre7 and 2.4.18-pre8 broke the Intuos part in
> > wacom.c
> > This will fix it.
> >
> > --- linux/drivers/usb/wacom.c.org Tue May 14 00:40:12 2002
> > +++ linux/drivers/usb/wacom.c Tue May 14 00:41:31 2002
> > @@ -288,8 +288,8 @@
> > x = ((__u32)data[2] << 8) | data[3];
> > y = ((__u32)data[4] << 8) | data[5];
> >
> > - input_report_abs(dev, ABS_X, wacom->x);
> > - input_report_abs(dev, ABS_Y, wacom->y);
> > + input_report_abs(dev, ABS_X, wacom->x = x);
> > + input_report_abs(dev, ABS_Y, wacom->y = y);
> > input_report_abs(dev, ABS_DISTANCE, data[9] >> 4);
> >
> > if ((data[1] & 0xb8) == 0xa0) {
> /* general pen packet */
> >
>
> Can you ask lepied@xfree86.org if this will break anything else, as that
> change was in his patch that is found at:
> http://people.mandrakesoft.com/~flepied/projects/wacom/
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2002-05-14 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-14 8:31 [PATCH] 2.4.19-pre8 Fix for Intuos tablet in wacom.c Christer Nilsson
2002-05-14 15:37 ` Greg KH
2002-05-14 18:56 ` Christer Nilsson [this message]
2002-05-15 2:46 ` Greg KH
2002-05-15 8:54 ` Christer Nilsson
2002-05-16 22:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=IBEJLIFNGHPKEKCKODPDMEDODPAA.christer.nilsson@kretskompaniet.se \
--to=christer.nilsson@kretskompaniet.se \
--cc=greg@kroah.com \
--cc=lepied@xfree86.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).