From: Dexuan Cui <decui@microsoft.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>
Subject: RE: [PATCH] PCI: hv: Do not wait forever on a device that has disappeared
Date: Tue, 29 May 2018 21:28:27 +0000 [thread overview]
Message-ID: <KL1P15301MB00062308DD0D900D9A8943FDBF6D0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAHp75Vd9kiyOaSbaK6c4b7ucF23kgP0yQxKpUAGrjHgKfJprXA@mail.gmail.com>
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Tuesday, May 29, 2018 14:21
> On Thu, May 24, 2018 at 12:12 AM, Dexuan Cui <decui@microsoft.com>
> wrote:
> >
> > Before the guest finishes the device initialization, the device can be
> > removed anytime by the host, and after that the host won't respond to
> > the guest's request, so the guest should be prepared to handle this
> > case.
>
> > + while (true) {
> > + if (hdev->channel->rescind) {
> > + dev_warn_once(&hdev->device, "The device is
> gone.\n");
> > + return -ENODEV;
> > + }
> > +
> > + if (wait_for_completion_timeout(comp, HZ / 10))
> > + break;
> > + }
>
> Infinite loops are usually a red flags.
>
> What's wrong with simple:
>
> do {
> ...
> } while (wait_...(...) == 0);
>
> ?
Thanks for the suggestion, Andy!
The coding style you suggested looks better to me. :-)
> > + if (!ret)
> > + ret = wait_for_response(hdev, &comp);
>
> Better to use well established patterns, i.e.
>
> if (ret)
> return ret;
Agreed.
>
> > + if (!ret)
> > + ret = wait_for_response(hdev,
> &comp_pkt.host_event);
>
> Here it looks okay on the first glance, but better to think about it
> again and refactor.
> With Best Regards,
> Andy Shevchenko
I'll try to send out a patch to improve the coding style, after I address
Michael Kelley's concern of a race.
Thanks,
-- Dexuan
prev parent reply other threads:[~2018-05-29 21:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 21:12 [PATCH] PCI: hv: Do not wait forever on a device that has disappeared Dexuan Cui
2018-05-24 12:41 ` Lorenzo Pieralisi
2018-05-24 23:55 ` Dexuan Cui
2018-05-25 10:29 ` Lorenzo Pieralisi
2018-05-25 11:43 ` Haiyang Zhang
2018-05-25 13:56 ` Lorenzo Pieralisi
2018-05-29 0:19 ` Michael Kelley (EOSG)
2018-05-29 19:58 ` Dexuan Cui
2018-05-31 16:40 ` Michael Kelley (EOSG)
2018-05-31 21:01 ` Dexuan Cui
2018-05-29 21:20 ` Andy Shevchenko
2018-05-29 21:28 ` Dexuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=KL1P15301MB00062308DD0D900D9A8943FDBF6D0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM \
--to=decui@microsoft.com \
--cc=andy.shevchenko@gmail.com \
--cc=apw@canonical.com \
--cc=bhelgaas@google.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marcelo.cerri@canonical.com \
--cc=olaf@aepfle.de \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).