From: ChiaWei Wang <chiawei_wang@aspeedtech.com>
To: Joel Stanley <joel@jms.id.au>,
John Wang <wangzhiqiang.bj@bytedance.com>,
Lei YU <yulei.sh@bytedance.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Andrew Jeffery <andrew@aj.id.au>, Oskar Senft <osk@google.com>,
devicetree <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: RE: [PATCH 0/2] arm: aspeed: Add LPC uart routing support
Date: Wed, 1 Sep 2021 07:09:46 +0000 [thread overview]
Message-ID: <KL1PR0601MB37810C5AB662895C0C716C8391CD9@KL1PR0601MB3781.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <CACPK8XfeU0+w03fgYxXVMVYOW-2woXQtUZ4FEDri3MSe+80_Wg@mail.gmail.com>
Hi Joel,
> From: Joel Stanley <joel@jms.id.au>
> Sent: Wednesday, September 1, 2021 3:04 PM
>
> On Wed, 1 Sept 2021 at 06:22, Chia-Wei Wang
> <chiawei_wang@aspeedtech.com> wrote:
> >
> > Add LPC uart routing driver and the device tree nodes.
>
> Thanks for submitting this driver. There are many parties who are interested in
> this, so hopefully they can step forward and review.
>
> Is this LPC UART routing, or UART routing in general? I know the register to
> control the routing is hidden in the LPC space, but I thought it was just general
> routing. I would drop the LPC part of the name.
>
> You also need to update the bindings document with the new compatible string.
> Send a patch for Documentation/devicetree/bindings/mfd/aspeed-lpc.txt.
Thanks for the feedback.
The UART routing is general.
I will send a v2 patch which drops the LPC part of name.
And the compatible string will also be updated to the dt-bindings.
Chiawei
prev parent reply other threads:[~2021-09-01 7:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 6:22 [PATCH 0/2] arm: aspeed: Add LPC uart routing support Chia-Wei Wang
2021-09-01 6:22 ` [PATCH 1/2] soc: aspeed: Add LPC UART " Chia-Wei Wang
2021-09-01 7:36 ` Joel Stanley
2021-09-01 9:43 ` ChiaWei Wang
2021-09-01 6:22 ` [PATCH 2/2] ARM: dts: aspeed: Add uart routing to device tree Chia-Wei Wang
2021-09-01 7:03 ` [PATCH 0/2] arm: aspeed: Add LPC uart routing support Joel Stanley
2021-09-01 7:09 ` ChiaWei Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=KL1PR0601MB37810C5AB662895C0C716C8391CD9@KL1PR0601MB3781.apcprd06.prod.outlook.com \
--to=chiawei_wang@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=osk@google.com \
--cc=robh+dt@kernel.org \
--cc=wangzhiqiang.bj@bytedance.com \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).