From: ultracoolguy@tutanota.com
To: Marek Behun <kabel@blackhole.sk>
Cc: Pavel <pavel@ucw.cz>, Dmurphy <dmurphy@ti.com>,
Linux Leds <linux-leds@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lm3697: Rename struct into more appropiate name
Date: Wed, 7 Oct 2020 14:21:56 +0200 (CEST) [thread overview]
Message-ID: <MJ2-gcy----2@tutanota.com> (raw)
In-Reply-To: <20201007012600.3b3e7779@blackhole.sk>
The reason I didn't use git send-mail earlier is because Tutanota doesn't supports SMTP and Protonmail requires a paid account for using SMTP/IMAP. However, I made an account creation request for Disroot(which does support SMTP for free), so when/if the account gets created I'll send future patches through there.
Oct 6, 2020, 23:26 by kabel@blackhole.sk:
> On Mon, 5 Oct 2020 22:17:14 +0200 (CEST)
> ultracoolguy@tutanota.com wrote:
>
>> Subject says it all. This rename was briefly discussed in this other patch: https://www.spinics.net/lists/linux-leds/msg16865.html (I don't know another way to link to emails, so I'll just use this archive).
>>
>> Feel free to suggest another name for the commit; that was just the better name I could come up with :/ .
>>
>>
>>
>
> Gabriel,
>
> the subject of the patch should be
> leds: lm3697: Rename struct into more appropiate name
> ("leds: " is prefixed). Look at history
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/leds?h=v5.9-rc8
>
> The commit message should mention why you are renaming the type
> (something like "to be semantically more correct, since that structure
> represents LED control bank as described by the datasheet").
>
> Also it seems that you are using git format-patch for generating patch
> files, but you are sending these patches as regular e-mail attachements.
> You should instead use git send-email, as is normally required
> for kernel patches (and they would also appear in patchwork
> (https://patches.linaro.org/project/linux-leds/list/). Please look at
> https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
> and https://git-send-email.io/.
>
> Marek
>
next prev parent reply other threads:[~2020-10-07 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 20:17 [PATCH] lm3697: Rename struct into more appropiate name ultracoolguy
2020-10-06 23:26 ` Marek Behun
2020-10-07 12:21 ` ultracoolguy [this message]
2020-10-07 14:56 ` Dan Murphy
2020-10-08 12:10 ` ultracoolguy
2020-10-08 15:27 ` ultracoolguy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MJ2-gcy----2@tutanota.com \
--to=ultracoolguy@tutanota.com \
--cc=dmurphy@ti.com \
--cc=kabel@blackhole.sk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).